Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124501
Message-ID: <c9736385-94b7-4064-911f-e5fc1df7e2bd@gmx.de>
Date: Fri, 19 Jul 2024 00:51:47 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] Request for opinions: bug vs feature - change
 intokenization of yield from
Content-Language: de-DE
To: Bob Weinand <bobwei9@hotmail.com>,
 Juliette Reinders Folmer <php-internals_nospam@adviesenzo.nl>
Cc: PHP internals <internals@lists.php.net>
References: <66984FD0.5090805@adviesenzo.nl>
 <AM8P250MB0170FFCA0014FB9EC272DB4FE2AC2@AM8P250MB0170.EURP250.PROD.OUTLOOK.COM>
In-Reply-To: <AM8P250MB0170FFCA0014FB9EC272DB4FE2AC2@AM8P250MB0170.EURP250.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:QHvLpyDklQM=;0cFMqDnX4lbSrQa/BTciTz8+GVX
 jP2vVCmJ4U89Cp7tfWNKnF6Ih7cpeeO3REAApEzi8LeVk4dW+U2vfayaDy7cOoL90JIJmcuEp
 xmvWqjYD3GAmm4VgaH66EEf4ae38ULGLihCL5zHbZlabif91CzsdsgVRFSrmgxIkOTCUf4W6N
 sLyRALtRlxiSqQG74n0UjDjKnmrFK+kGd6y3wjX3d8tu9GGmFOv2e0rQfem8QtH3EF3cHsTN9
 Eq1vDLM0DLhKtZQzKMyY4cHsO/UWmAc0D3srgscTJL024C80/9UeWt4JgzappD6cog2PrXbFZ
 Yd69cwwJprzXsMavU5atDhMB1PQ+9hAGvGJLPJXIAZ9lLY7deXKGRqMTs0HYv7RMpy1BNaEhp
 SJEhHx4B0Fvzp3R5M5/wj7yU712CHn5a4uczIMkdcIPguT5hqmHqOEXhti1tM91t1LjzbpTxS
 lWCMkE3aXFhLLq2AMMFLdl2kms28rjJ8Mzqr3Us2UjIkMAFShrmF2+ikfjMA+5amUfvpvEbsF
 aJGlvBo7U3/myenVlPP1l7bAk+EDHRigj58MJxQ4C4idI6pggvVXwxSic0uP0s3WDYOWX+vxf
 dVWhIVhPITgYJJpBZweoKsXc+YNvn2x8z/Bhc8fsfmTyrz+t7X2aqKIWnSsgZmCNGNEC5SGn2
 dVZp4kbQXyPAiUqp00Tx/jVSLg8w8/kF0AUgT0zEKFcIF8l596l25fFU83Gt3ypdpF5KStQVY
 IZMQ2nEqulnH4IGrd2QU8oKoLX+HLXtK+BwLh8O88QBIyDq6GXmkiTsQjYlL6aHIzeE5vDeWn
 g2OPT4nyGTsCLZul7crZSDQA==
From: cmbecker69@gmx.de ("Christoph M. Becker")

Hi Bob!

On 18.07.2024 at 15:41, Bob Weinand wrote:

> Moreover, it can - at least - be worked around in tooling by special cas=
ing the T_YIELD_FROM token and extracting the comment from the raw parsed =
string:
>
> var_dump(token_get_all('<?php yield /* comment */ from $foo;'));
>
> will contain:
>
> [1]=3D> array(3) { [0]=3D> int(270) [1]=3D> string(24) "yield /* comment=
 */ from" [2]=3D> int(1) }
>
> It's not optimal, but probably the least bad solution to leave it unchan=
ged in PHP 8.3, have tooling special case it and properly fix it in PHP 8.=
4.

And what about "code" like <https://3v4l.org/4CLhM>?  Is Codesniffer
supposed to scan the result of <https://3v4l.org/dKDcs> for possible CS
violations?

Cheers,
Christoph