Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124496
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
Mime-Version: 1.0 (1.0)
Subject: Re: [PHP-DEV] Request for opinions: bug vs feature - change in tokenization of yield from
Date: Thu, 18 Jul 2024 16:24:22 -0300
Message-ID: <50659A48-36DE-487D-9976-EC4B409627B1@gmail.com>
References: <f6ff45c5-94b9-4ebd-b9ab-c9a9ba42b7e7@bastelstu.be>
Cc: Juliette Reinders Folmer <php-internals_nospam@adviesenzo.nl>,
 PHP internals <internals@lists.php.net>
In-Reply-To: <f6ff45c5-94b9-4ebd-b9ab-c9a9ba42b7e7@bastelstu.be>
To: =?utf-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
From: deleugyn@gmail.com (=?utf-8?Q?Marco_Aur=C3=A9lio_Deleu?=)

I can't speak for Juliette's plans but I would advocate for pinning PHP 8.3.=
{fixed} on Composer and having an error message for PHAR. It's also worth me=
ntioning that just because it's possible to add comments in those versions d=
oesn't mean we must assume that it wi be done and it must be supported. If a=
 Ubuntu LTS user gets an error, pointing out that they're relying on an acci=
dental behavior only present in 9 patch releases of the entire PHP lifecycle=
 seems good enough.

> On 18 Jul 2024, at 16:05, Tim D=C3=BCsterhus <tim@bastelstu.be> wrote:
>=20
> =EF=BB=BFHi
>=20
>> On 7/18/24 19:48, Marco Aur=C3=A9lio Deleu wrote:
>> Forcing all tooling that uses token_get_all() to handle this unintentiona=
l change seems to generate more unnecessary and real busywork for something o=
nly theoretical possible to break.
>=20
> The tools are required to handle this either way, because there are releas=
ed version with this specific tokenization and they are not going away.
>=20
> Ubuntu 24.04 LTS ships with PHP 8.3.6 and generally Ubuntu backports secur=
ity fixes instead of upgrading to newer patch versions. As an example, Ubunt=
u 22.04 LTS ships with PHP 8.1.2 + security fixes, not with 8.1.29 (which is=
 the newest 8.1.x as of now).
>=20
> Thus the ship has effectively sailed due to the inclusion in Ubuntu 24.04 L=
TS as the arguably most widely used Linux distro.
>=20
> Best regards
> Tim D=C3=BCsterhus