Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124491
Message-ID: <ea72cbed-6a19-4e95-8de4-72413cb0697b@bastelstu.be>
Date: Thu, 18 Jul 2024 20:57:21 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] [RFC] Deprecations for PHP 8.4
To: "Christoph M. Becker" <cmbecker69@gmx.de>,
 Juliette Reinders Folmer <php-internals_nospam@adviesenzo.nl>,
 internals@lists.php.net
References: <bw20I5b7ly3lSbI-2Bv3kfrfTVJbDo5RhwBiQa1PEwuLjprDJWptPajLiaialj1RLVKu7z1j0MofJUhhRVtzT_5i2E11oKeQx_VMUxnKhUE=@gpb.moe>
 <6683CDE4.7050607@adviesenzo.nl>
 <Skh-IB3l7OxslclNZdB5ZE3G5PaIvpoz3iojK10noNbXkj1odNNvzI5w7X1aSj7IKZ951646yQ8IrUW_wNaQuv94NB0jo3IXlFImcpu_hxc=@gpb.moe>
 <668B5728.40300@adviesenzo.nl> <61cbb650-17d7-4dbf-a73b-8265d6af2d4f@gmx.de>
 <36c412df-7752-4554-af6b-d4696fbd2011@bastelstu.be>
 <84d2e07c-f0b4-418c-95c6-ec760dac9146@gmx.de>
Content-Language: en-US
In-Reply-To: <84d2e07c-f0b4-418c-95c6-ec760dac9146@gmx.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 7/16/24 13:04, Christoph M. Becker wrote:
> See also a respective GH issue regarding deprecation messages:
> <https://github.com/php/php-src/issues/14320>; it probably makes sense
> to include an URL in the deprecation message, or maybe some code which
> users can use to look up more thorough information about the deprecation.

To loop the list back in: I've replied to that issue that as part of the 
#[\Deprecated] RFC implementation new deprecation messages were added to 
(almost) all functions that are currently deprecated:

https://github.com/php/php-src/pull/14750

In case of utf8_decode() / utf8_encode() the message just points towards 
the documentation, but there is an extensive explanation discussing the 
possible alternatives, for the others the message already points out the 
alternatives or explains the deprecation in another way (e.g. for the 
*_free() functions that became obsolete when moving from resources to 
objects).

For uniqid() there are already various warnings in the documentation and 
today a PR was merged to adjust the description text to avoid using the 
word "unique", because it was factually untrue:

https://github.com/php/doc-en/pull/3571

If the deprecation is accepted, then the list of possible alternatives 
that are already mentioned in the RFC can be included in the documentation.

Best regards
Tim Düsterhus