Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124486
Precedence: bulk
MIME-Version: 1.0
References: <b3bfdb8b-66c7-4628-b7a7-d065f2022180@gmx.de> <CAPyj-LDSRKMzWvBS2+HuKFoPy6JBk5ZRvQ9Fyjum_G5YC0sg6Q@mail.gmail.com>
In-Reply-To: <CAPyj-LDSRKMzWvBS2+HuKFoPy6JBk5ZRvQ9Fyjum_G5YC0sg6Q@mail.gmail.com>
Date: Thu, 18 Jul 2024 19:45:07 +0200
Message-ID: <CAAfnsFXErxzKGbmMMC1_-Tpxj+5j9b_rLfr6_LovkhM=T5SQCg@mail.gmail.com>
Subject: Re: [PHP-DEV] Sync CODEOWNERS
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000002b0595061d892472"
From: petk@php.net (Peter Kokot)

--0000000000002b0595061d892472
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 18 Jul 2024, 16:32 Ilija Tovilo, <tovilo.ilija@gmail.com> wrote:

> Hi Christoph
>
> On Thu, Jul 18, 2024 at 2:09=E2=80=AFPM Christoph M. Becker <cmbecker69@g=
mx.de>
> wrote:
> >
> > So I suggest to sync CODEOWNERS for all active branches (and maybe even
> > security branches).
> >
> > What do you think?
>
> I think back when it was introduced it wasn't clear (at least to me)
> that PRs would request reviews based on the CODEOWNERS file of the
> target branch, rather than the default branch. Given that's how it
> works, syncing it in all active branches makes sense to me.
>
> Ilija
>

I think that nothing will help solve this issue but to write also some
comment in that file on top to send updates to the earliest supported
branch, and not the master branch only.

We were resolving this in the past not so long ago:
https://github.com/php/php-src/pull/13591

>

--0000000000002b0595061d892472
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D=
"gmail_attr">On Thu, 18 Jul 2024, 16:32 Ilija Tovilo, &lt;<a href=3D"mailto=
:tovilo.ilija@gmail.com">tovilo.ilija@gmail.com</a>&gt; wrote:<br></div><bl=
ockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #=
ccc solid;padding-left:1ex">Hi Christoph<br>
<br>
On Thu, Jul 18, 2024 at 2:09=E2=80=AFPM Christoph M. Becker &lt;<a href=3D"=
mailto:cmbecker69@gmx.de" target=3D"_blank" rel=3D"noreferrer">cmbecker69@g=
mx.de</a>&gt; wrote:<br>
&gt;<br>
&gt; So I suggest to sync CODEOWNERS for all active branches (and maybe eve=
n<br>
&gt; security branches).<br>
&gt;<br>
&gt; What do you think?<br>
<br>
I think back when it was introduced it wasn&#39;t clear (at least to me)<br=
>
that PRs would request reviews based on the CODEOWNERS file of the<br>
target branch, rather than the default branch. Given that&#39;s how it<br>
works, syncing it in all active branches makes sense to me.<br>
<br>
Ilija<br></blockquote></div></div><div dir=3D"auto"><br></div><div dir=3D"a=
uto">I think that nothing will help solve this issue but to write also some=
 comment in that file on top to send updates to the earliest supported bran=
ch, and not the master branch only.</div><div dir=3D"auto"><br></div><div d=
ir=3D"auto">We were resolving this in the past not so long ago:</div><div d=
ir=3D"auto"><a href=3D"https://github.com/php/php-src/pull/13591">https://g=
ithub.com/php/php-src/pull/13591</a><br></div><div dir=3D"auto"><div class=
=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8=
ex;border-left:1px #ccc solid;padding-left:1ex">
</blockquote></div></div></div>

--0000000000002b0595061d892472--