Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124476
Feedback-ID: ifab94697:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-568-g843fbadbe-fm-20240701.003-g843fbadb
Precedence: bulk
MIME-Version: 1.0
Message-ID: <b1308786-48ac-4b2e-bd42-baf6b013db18@app.fastmail.com>
In-Reply-To: 
 <CABY-Mhz5P+QgoTgfHd1RV2=U_YV7VT0Yn08C9E98DNr93+9w1g@mail.gmail.com>
References: 
 <CABY-Mhz36WtLx_1bWAmK8rUpqAQTEw3H1mziPa5TH4nEgeHYFg@mail.gmail.com>
 <CANLbj-pk9FmHKG+PZcK-ua1DGKbHJ6wtsCKedKJdMSJZdM+aPw@mail.gmail.com>
 <CAPPUTHo-pfQNK_CKGTMm8fj1=VJaLvk5Y2iRpbCewuNBY48sSw@mail.gmail.com>
 <CABY-Mhz5P+QgoTgfHd1RV2=U_YV7VT0Yn08C9E98DNr93+9w1g@mail.gmail.com>
Date: Thu, 18 Jul 2024 15:12:23 +0200
To: "Oliver Nybroe" <olivernybroe@gmail.com>,
 "Lily Bergonzat" <lilybergonzat+php@gmail.com>
Cc: "Ayesh Karunaratne" <ayesh@php.watch>,
 "PHP internals" <internals@lists.php.net>
Subject: Re: [PHP-DEV] Optional constructor body
Content-Type: multipart/alternative;
 boundary=54bfe7fe66a04174837285be76a17a54
From: rob@bottled.codes ("Rob Landers")

--54bfe7fe66a04174837285be76a17a54
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 18, 2024, at 12:11, Oliver Nybroe wrote:
> Thanks for sharing previous discussions, I will definitely take a look=
 at those before writing up the RFC.=20
>=20
>=20
> > If you do with to go with an RFC, I'd like to see if your proposal
> addresses whether this syntax should implicitly call
> `parent::__construct()`, and if a semi colon is expected or not
> (`public function __construct(public int $foo);` vs `public function
> __construct(public int $foo)`).
> Thank you, these are very valuable points to address in the RFC.=20
>=20
> I can definitely feel that there will be some mixed opinions about sem=
icolon vs no semi colon.
>=20
>=20
> Best regards
> Oliver Nybroe (he/him)

Don't forget to bottom post :)

I have a feeling a semi-colon is going to be required to disambiguate:

public function __construct(protected string $foo) protected string $bar;

Without semi-colons, that is perfectly valid and confusing.

=E2=80=94 Rob
--54bfe7fe66a04174837285be76a17a54
Content-Type: text/html;charset=utf-8
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Thu, Jul 18,=
 2024, at 12:11, Oliver Nybroe wrote:<br></div><blockquote type=3D"cite"=
 id=3D"qt" style=3D""><div dir=3D"ltr"><div>Thanks for sharing previous =
discussions, I will definitely&nbsp;take a look at those before writing =
up the RFC.&nbsp;<br></div><div><br></div><div><br></div><div>&gt; If yo=
u do with to go with an RFC, I'd like to see if your proposal<br></div><=
div>addresses whether this syntax should implicitly call<br></div><div>`=
parent::__construct()`, and if a semi colon is expected or not<br></div>=
<div>(`public function __construct(public int $foo);` vs `public functio=
n<br></div><div>__construct(public int $foo)`).<br></div><div><div>Thank=
 you, these are very valuable points to address in the RFC.&nbsp;<br></d=
iv><div><br></div><div>I can definitely&nbsp;feel that there will be som=
e mixed opinions about semicolon&nbsp;vs no semi colon.<br></div></div><=
div><div><br></div><div><div><br></div><div><div dir=3D"ltr" class=3D"qt=
-gmail_signature"><div dir=3D"ltr"><div>Best regards<br></div><div>Olive=
r Nybroe (he/him)<br></div></div></div></div></div></div></div></blockqu=
ote><div><br></div><div>Don't forget to bottom post :)<br></div><div><br=
></div><div>I have a feeling a semi-colon is going to be required to dis=
ambiguate:<br></div><div><br></div><div>public function __construct(prot=
ected string $foo) protected string $bar;<br></div><div><br></div><div>W=
ithout semi-colons, that is perfectly valid and confusing.</div><div><br=
></div><div id=3D"sig121229152">=E2=80=94 Rob<br></div></body></html>
--54bfe7fe66a04174837285be76a17a54--