Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:124474 X-Original-To: internals@lists.php.net Delivered-To: internals@lists.php.net Received: from php-smtp4.php.net (php-smtp4.php.net [45.112.84.5]) by qa.php.net (Postfix) with ESMTPS id 910F61A00B7 for ; Thu, 18 Jul 2024 12:45:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=php.net; s=mail; t=1721306844; bh=0TgJtc3AYc1s75kZzHHMIgXo6nArzUnIffi7+N0S6M8=; h=Date:Subject:To:References:From:In-Reply-To:From; b=nR9ZhIyXNJcMRKNojCtLDJmdy+5FVSIwzmAMZJWIhbW12HDQM81b3GJqAw0qc8F7x 6TTDXnvsV8b5ADPkMDD9aHFUimqTWW0kqR3uCTYte6//GjH2DW/RVo/XAF1ZekkHm1 g290+0bA5cAp39X99ABdM4F+RQ9uFLgDw1aGdMQ+ZcTqpIB8gbNvCDfp+GaEHOm/H9 htpxyI452WsheUzAoTXoE6ozQdR7mAvDSzdm8w1gB81S1C5RaPYVcI0QCwQRFUTEkO xGzyS2WHSe4Yivf/kCtsD2z7dhqw2VR2K48uSIZYhZdzDd6epgFuVIG96H7syne0rt 2v2hBUVzLU2xg== Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 70E441805AD for ; Thu, 18 Jul 2024 12:47:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_50,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,DMARC_PASS,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=4.0.0 X-Spam-Virus: No X-Envelope-From: Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Thu, 18 Jul 2024 12:47:23 +0000 (UTC) Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-426717a2d12so1982575e9.0 for ; Thu, 18 Jul 2024 05:45:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721306752; x=1721911552; darn=lists.php.net; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=SbKtvrsewHpRFAHyiwbVhzE88eFlTLUjmSSgR1NnDhY=; b=HYb2koaK4n5wyPPRIPCZg8VaUs8vm+CErg4Z0estd+WJIPJV5OfiIParupepH3hqs5 DI62nPTu7z6z7gDI3xW6fgQsdxQXDKKyP66Ku7ntkRlre9eHaYstjBgCO/j3cnW2ZwuT hdxHMtDLJwOvsjNaI5/NyRMwu1Rzd/8gRiXUsP9niSVapk3TaguCRTQpl/IMeRPrjDVH nhljX1dCoEXDQmJKNeawGx2ce694v1nSTZomQhGJnGtfFHZ0nRViy6tBVHpHdyjDkkWx dLPsH7hTR7HluREwfs8dwodbOVx9DeYyTNphOinbFo5qX2QrZ8uel1CvWQvjmN6F2RQc ZLLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721306752; x=1721911552; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SbKtvrsewHpRFAHyiwbVhzE88eFlTLUjmSSgR1NnDhY=; b=kKFFHWAMLIzmAnP876YfmjOdBF6H5+6AnJ7+n9Q52lxDNDPtqXH67lsk744B7GO+Oc LYbZEblQ+8PxSpH2WXWrIXjZfPeLJrtwpm/QfvmO3L1XKb8DVsDlkO5vE/xSUZmDhKDp 82gM67RXYD59JMUlbj5MwhP1rWPqVy7PSOGtigz7WZKB1dXoU0RQUAuyzB97F6OeMpHg zYNRywcHhRUx4GLZyUrt0w/3BMaKgN/Npsyh2Ig0+4p5CQ5iFUUEVQkhfJuo6YhIaqsK sCyx78+fZKokhU0+1wgusmBL09T4MUjlXQ3nIkUcjbmQTSBAhPyXpNdCW+ehwCHK1t7g Z6zw== X-Gm-Message-State: AOJu0YwV+EDCLEGTaaekAoa3+VB2Hnxa09Q8n8kOm1tvJLCKF11zCbBK sYkmts+j90zviFJu3CXYr4UtxvHbGtMs5pyF53PM3ZSs6OB8R08awTDF2vlV X-Google-Smtp-Source: AGHT+IGjXNaKA7TQQfsQOA/0UztYM+by8Fap22QWOCO68u6B5oJQ8BIRH1ES3e3oiUA55Pp9PTkl9A== X-Received: by 2002:a05:600c:5486:b0:427:aab7:976b with SMTP id 5b1f17b1804b1-427d2a8e1b1mr7399485e9.5.1721306751937; Thu, 18 Jul 2024 05:45:51 -0700 (PDT) Received: from [192.168.0.103] (178-117-134-240.access.telenet.be. [178.117.134.240]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427d2a8d8f9sm12656175e9.37.2024.07.18.05.45.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jul 2024 05:45:51 -0700 (PDT) Message-ID: Date: Thu, 18 Jul 2024 14:44:42 +0200 Precedence: bulk list-help: list-post: List-Id: internals.lists.php.net x-ms-reactions: disallow MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PHP-DEV] Sync CODEOWNERS To: internals@lists.php.net References: Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit From: dossche.niels@gmail.com (Niels Dossche) On 18/07/2024 14:08, Christoph M. Becker wrote: > Hi all! > > I have noticed that the CODEOWNERS of php-src are apparently not synced > for all active branches[1][2]. However, it seems to me that this > doesn't make sense; if someone provides a PR against some lower branch, > the most recent CODEOWNERS may not be notified, and modifications might > be send to possibly inactive maintainers. This is particularly > confusing if the base branch of an PR will be changed; all over sudden > new reviews may be requested. > > So I suggest to sync CODEOWNERS for all active branches (and maybe even > security branches). > > What do you think? > > [1] > [2] > > Cheers, > Christoph Hi I believe they should be synced indeed, although we should be careful with extensions that are dropped from PHP (e.g. imap). Those entries should remain only in 8.2 and 8.3 but not in master. Kind regards Niels