Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124457
Content-Type: multipart/alternative;
 boundary="------------yWhzTOQwJ70U0vDp0h8QnlZx"
Message-ID: <356aa359-e109-4b2f-82e2-e15fcaf0c64d@scriptfusion.com>
Date: Wed, 17 Jul 2024 10:01:33 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] array_reduce callback key
To: Levi Morrison <levi.morrison@datadoghq.com>
Cc: PHP Internals List <internals@lists.php.net>
References: <5bdbffef-4954-415d-9dae-4c9bd4ba0f22@scriptfusion.com>
 <CAAKU0u=JNHNkhcCxOQ3fzY9Eu1xiQoyb3fNPJgHtY9P6jYxn0A@mail.gmail.com>
Content-Language: en-GB
In-Reply-To: <CAAKU0u=JNHNkhcCxOQ3fzY9Eu1xiQoyb3fNPJgHtY9P6jYxn0A@mail.gmail.com>
From: bilge@scriptfusion.com (Bilge)

This is a multi-part message in MIME format.
--------------yWhzTOQwJ70U0vDp0h8QnlZx
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 17/07/2024 01:41, Levi Morrison wrote:
> Adding arguments to a function can mess up internal callbacks, btw, so I don't like modifying the
> existing function.

Which internal callbacks can be messed up by this change? They clearly 
aren't tested, as the build is passing.

Cheers,
Bilge

--------------yWhzTOQwJ70U0vDp0h8QnlZx
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">On 17/07/2024 01:41, Levi Morrison
      wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAAKU0u=JNHNkhcCxOQ3fzY9Eu1xiQoyb3fNPJgHtY9P6jYxn0A@mail.gmail.com">
      <pre class="moz-quote-pre" wrap=""><span
      style="white-space: pre-wrap">Adding arguments to a function </span>can mess up internal callbacks, btw, so I don't like modifying the
existing function.
</pre>
    </blockquote>
    <p>Which internal callbacks can be messed up by this change? They
      clearly aren't tested, as the build is passing.</p>
    <p>Cheers,<br>
      Bilge<br>
    </p>
  </body>
</html>

--------------yWhzTOQwJ70U0vDp0h8QnlZx--