Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124453
Precedence: bulk
MIME-Version: 1.0
References: <5bdbffef-4954-415d-9dae-4c9bd4ba0f22@scriptfusion.com>
In-Reply-To: <5bdbffef-4954-415d-9dae-4c9bd4ba0f22@scriptfusion.com>
Date: Tue, 16 Jul 2024 18:41:06 -0600
Message-ID: <CAAKU0u=JNHNkhcCxOQ3fzY9Eu1xiQoyb3fNPJgHtY9P6jYxn0A@mail.gmail.com>
Subject: Re: [PHP-DEV] array_reduce callback key
To: Bilge <bilge@scriptfusion.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: levi.morrison@datadoghq.com (Levi Morrison)

On Tue, Jul 16, 2024 at 5:17=E2=80=AFPM Bilge <bilge@scriptfusion.com> wrot=
e:
>
> Hi Internals,
>
> I just ran into a case where I needed the array key in an array_reduce()
> callback, but I can't access it :(
>
> So I wrote a PR to fix it: https://github.com/php/php-src/pull/14986
>
> What do you think? Does this need an RFC?
>
> Cheers,
> Bilge

I don't think it's reasonable to cover every use-case "nicely" in the
standard library. You didn't give a real example. You might consider
using array_walk or iterator_apply, or a foreach loop depending on
what you need.

I am curious what your real use-case is. It may be worth adding
something. It might not. Hard to tell. Adding arguments to a function
can mess up internal callbacks, btw, so I don't like modifying the
existing function.