Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124446
Precedence: bulk
MIME-Version: 1.0
References: <CAOWwgpmbq5VRrZQvUXDsKiNK4r6+bFA4VxnjQ_U=h8T9r0o3DA@mail.gmail.com>
 <ab83af79-0669-47dd-a3cb-ab72327ae174@bastelstu.be> <CAP1Jc13JWVg99AULgzrGXcoCWJtJZGz+nr_VoyUocw8n5n5sfQ@mail.gmail.com>
 <1118bbcd-a7b4-47bf-bf35-1a36ab4628e1@bastelstu.be> <CAP1Jc11vNiazMRL8Y-4NcJhsEkg6kgFNKLymTGfEPYRv114oTA@mail.gmail.com>
 <45847b93-02bf-459f-bcd2-81ba35a12c24@bastelstu.be> <CAOWwgpnt77-Sybzc3hcnFEui9t8wAv03NAov4xCK9ib_VRZ0JA@mail.gmail.com>
 <46bd4098-2936-4e46-98e9-fe55118325c2@bastelstu.be> <CAOWwgpkCy++W1C2t0PnkZ71S8vq1B734ZNPGw2-OHjmrwO3L4A@mail.gmail.com>
 <61ab36bc-b045-452a-84e0-87367d4c680e@bastelstu.be> <CAEPJduk6m1gdPOrsXYbsc+RLuHeEBav3pGwQO+PHs4UGGqtzhg@mail.gmail.com>
 <07e065f2-8f64-4bad-9a98-51f4eaf63ddb@app.fastmail.com> <CAOWwgpngQtg2NRW6M6RwgSH+OS1iipewHBmM5c36P2MxQGX78A@mail.gmail.com>
 <2a0a4650-c2c5-4c6d-ad3a-25365b3391b2@bastelstu.be>
In-Reply-To: <2a0a4650-c2c5-4c6d-ad3a-25365b3391b2@bastelstu.be>
Date: Tue, 16 Jul 2024 10:13:56 +0200
Message-ID: <CAOWwgpm9FLy_SNt7HLtJh5sxtfwjZMMN6pOKioDqsJc+GgD-sA@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Lazy Objects
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: Rob Landers <rob@bottled.codes>, =?UTF-8?Q?Benjamin_Au=C3=9Fenhofer?= <kontakt@beberlei.de>, 
	PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000013c6e4061d58eeb6"
From: nicolas.grekas+php@gmail.com (Nicolas Grekas)

--00000000000013c6e4061d58eeb6
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Le lun. 15 juil. 2024 =C3=A0 21:42, Tim D=C3=BCsterhus <tim@bastelstu.be> a=
 =C3=A9crit :

> Hi
>
> On 7/15/24 09:25, Nicolas Grekas wrote:
> > Testing is actually a good domain where resetting lazy objects might op=
en
> > interesting use cases.
> > This reminded me about zenstruck/foundry, which leverages the
> > LazyProxyTrait to provide refreshable fixture objects
> > <
> https://symfony.com/bundles/ZenstruckFoundryBundle/current/index.html#aut=
o-refresh
> >
> > and provides nice DX thanks to this capability.
> >
>
> I have not used this library before, but I have taken a (very) brief
> look at the code and documentation.
>
> My understanding is that all the fixture objects are generated by a
> corresponding Factory class. This factory clearly has the capability of
> constructing objects by itself, so it could just create a lazy proxy
> instead?
>
> I'm seeing the `instantiateWith()` example in the documentation where
> the user can return a constructed object themselves, but I'm not seeing
> how that can safely be combined with the `reset*()` methods: Anything
> special the user did to construct the object would be reverted, so the
> user might as well rely on the default construction logic of the factory
> then.
>
> What am I missing?
>

Finding the spot where the reset method would be useful is not easy. Here
it is:
https://github.com/zenstruck/foundry/blob/v2.0.7/src/Persistence/IsProxy.ph=
p#L66-L76

Basically, the reset method is not needed when creating the lazy proxy. But
it's needed to refresh it when calling $object->_refresh(). The
implementation I just linked swaps the real object bound to the proxy for
another one (the line
"Configuration::instance()->persistence()->refresh($object);" swaps by
reference).

--00000000000013c6e4061d58eeb6
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">Le=C2=A0lun. 15 juil. 2024 =C3=A0=C2=
=A021:42, Tim D=C3=BCsterhus &lt;<a href=3D"mailto:tim@bastelstu.be">tim@ba=
stelstu.be</a>&gt; a =C3=A9crit=C2=A0:<br></div><blockquote class=3D"gmail_=
quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,=
204);padding-left:1ex">Hi<br>
<br>
On 7/15/24 09:25, Nicolas Grekas wrote:<br>
&gt; Testing is actually a good domain where resetting lazy objects might o=
pen<br>
&gt; interesting use cases.<br>
&gt; This reminded me about zenstruck/foundry, which leverages the<br>
&gt; LazyProxyTrait to provide refreshable fixture objects<br>
&gt; &lt;<a href=3D"https://symfony.com/bundles/ZenstruckFoundryBundle/curr=
ent/index.html#auto-refresh" rel=3D"noreferrer" target=3D"_blank">https://s=
ymfony.com/bundles/ZenstruckFoundryBundle/current/index.html#auto-refresh</=
a>&gt;<br>
&gt; and provides nice DX thanks to this capability.<br>
&gt; <br>
<br>
I have not used this library before, but I have taken a (very) brief <br>
look at the code and documentation.<br>
<br>
My understanding is that all the fixture objects are generated by a <br>
corresponding Factory class. This factory clearly has the capability of <br=
>
constructing objects by itself, so it could just create a lazy proxy <br>
instead?<br>
<br>
I&#39;m seeing the `instantiateWith()` example in the documentation where <=
br>
the user can return a constructed object themselves, but I&#39;m not seeing=
 <br>
how that can safely be combined with the `reset*()` methods: Anything <br>
special the user did to construct the object would be reverted, so the <br>
user might as well rely on the default construction logic of the factory <b=
r>
then.<br>
<br>
What am I missing?<br></blockquote><div><br></div><div>Finding the spot whe=
re the reset method would be useful is not easy. Here it is:</div><div><a h=
ref=3D"https://github.com/zenstruck/foundry/blob/v2.0.7/src/Persistence/IsP=
roxy.php#L66-L76">https://github.com/zenstruck/foundry/blob/v2.0.7/src/Pers=
istence/IsProxy.php#L66-L76</a></div><div><br></div><div>Basically, the res=
et method is not needed when creating the lazy proxy. But it&#39;s needed t=
o refresh it when calling $object-&gt;_refresh(). The implementation I just=
 linked swaps the real object bound to the proxy for another one (the line =
&quot;Configuration::instance()-&gt;persistence()-&gt;refresh($object);&quo=
t; swaps by reference).<br></div><div><br></div><div><br></div></div></div>

--00000000000013c6e4061d58eeb6--