Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124420
Content-Type: text/plain;
	charset=utf-8
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\))
Subject: Re: [PHP-DEV] Breaking change of rounding behavior in PHP 8.4
In-Reply-To: <2ec18797-60bd-4e11-adf3-c106c9699446@gmx.de>
Date: Sat, 13 Jul 2024 23:01:45 +0900
Cc: Claude Pache <claude.pache@gmail.com>,
 PHP Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <D97763B3-8BD0-4836-A338-163917169F45@sakiot.com>
References: <596bed4d-81a5-4cd4-8af6-1e2c54fd1ffe@gmx.de>
 <F253BAC9-7AB6-4A51-8401-2357F8524912@sakiot.com>
 <2ec18797-60bd-4e11-adf3-c106c9699446@gmx.de>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
From: saki@sakiot.com (Saki Takamachi)

Hi Christoph,

> 2024/07/13 22:30=E3=80=81Christoph M. Becker =
<cmbecker69@gmx.de>=E3=81=AE=E3=83=A1=E3=83=BC=E3=83=AB:
>=20
> Hi Saki!
>=20
> On 13.07.2024 at 15:16, Saki Takamachi wrote:
>>=20
>>>> On 12.07.2024 at 17:26, Claude Pache wrote:
>>>>=20
>>>> See [1] and [2], which motivated the change.
>>>=20
>>> Ah, thank you!  I probably should have checked this more =
thouroughly;
>>> now even I can see that there was a *bug*, so it is okay for me to =
stick
>>> with the fix (thank you, Saki!), [=E2=80=A6]
>>>=20
>>>> [1]: =
https://github.com/php/php-src/issues/12143#issuecomment-1713465981
>>>> [2]: https://3v4l.org/3Q7BC
>>=20
>> If this can be considered a bug fix, then I'm in favor of keeping it =
as is. (I wasn't sure if this should be considered a feature addition.)
>=20
> Well, if I call round() and tell it to round to zero decimals, and it
> doesn't do it (assuming precision=3D-1), that looks like a bug to me.
>=20
>> I will update UPGRADING with concrete examples.
>=20
> Thank you!
>=20
> Cheers,
> Christoph

I opened the PR.
https://github.com/php/php-src/pull/14943

FYI, the test case for that value already exists :)
=
https://github.com/php/php-src/blob/520787bb93990b95d9cf6eaf063ca2b03b76a8=
7f/ext/standard/tests/math/round_gh12143_expand-rounding-target.phpt#L14

Regards,

Saki=