Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124419
Message-ID: <2ec18797-60bd-4e11-adf3-c106c9699446@gmx.de>
Date: Sat, 13 Jul 2024 15:30:39 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] Breaking change of rounding behavior in PHP 8.4
Content-Language: de-DE
To: Saki Takamachi <saki@sakiot.com>
Cc: Claude Pache <claude.pache@gmail.com>,
 PHP Internals <internals@lists.php.net>
References: <596bed4d-81a5-4cd4-8af6-1e2c54fd1ffe@gmx.de>
 <F253BAC9-7AB6-4A51-8401-2357F8524912@sakiot.com>
In-Reply-To: <F253BAC9-7AB6-4A51-8401-2357F8524912@sakiot.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:TDWKFh5J+EU=;9fita0vmE19974PxnbHxOx6Zpel
 fct0cjnrsnTD/WV/DkzfCmxkge2sdWQ5G3EjCPiDcgDfK2+VuxqxEscJ5KYQZrnNeTC+h3pMy
 Au4s2Rzvf5elpOPqk9nXAAf25gk5RWzkZ8UcaI3SNujUVrxA5KWW7jZsGaCFb3DwK8HXyhLX+
 xB4s+E6BQ4GS8DBWTFmopEHLcwvy8XhS0uDac/azhbTwYDI1YNddKLbGDzFK0hkElBVz5Eb5L
 3OM6Idz+mpqogGW8hJRwAhzSCG9WQs2gOpCsGK8ULLrvZkjGhLgeHi8M5v9ifstf0lVlo50St
 YtI+QL6ypo/RzLrak9EGTwS2eXjkDP4kcPo0wlkeXuZbpcUk8TldDH7Qq2IfBUf0TR0tu5sgO
 yQNzUb9JYnKGtA/JiZcxhtA+ner5JJm0YO6gW9nHcvQVuH947oIYAf0rJS50mQj43ZIK3vvqc
 GxcqebL5R645nZ2O8BVPDwdXoflnyY62ntTEwMlBxu5Z0vemPEC35BUcJQkQC7ht4mj31kwp2
 ztUCeyDhaY2+uuHmS/0bceBIkLcGk9Ehw6Rajng9PCGQIVsHrgW981dMhaJPR8Q9lJXOvqj17
 yFrJlh4qCI9BAmUcUHCgDLqArE6gV1mPrJLh4ZEQSdE0HbOE6Aubj8cKGR3QXs1KZL0rm7PUF
 XhJEWneNGrLzz5yVnLSa5EKoB3LefQR8VPjmzvGFHMz24XMXjNM8NyZN56kwDuSpQ1FfEyC5+
 eoE3Dz2ePCARSm1anK647ALtHg/IfISTEZ8QQ1A/pK0r5ZMIzCPunbsKaa4al62mPwYHraMpa
 cHTV8GD+2P49qrffW5rocUQQ==
From: cmbecker69@gmx.de ("Christoph M. Becker")

Hi Saki!

On 13.07.2024 at 15:16, Saki Takamachi wrote:
>
>>> On 12.07.2024 at 17:26, Claude Pache wrote:
>>>
>>> See [1] and [2], which motivated the change.
>>
>> Ah, thank you!  I probably should have checked this more thouroughly;
>> now even I can see that there was a *bug*, so it is okay for me to stic=
k
>> with the fix (thank you, Saki!), [=E2=80=A6]
>>
>>> [1]: https://github.com/php/php-src/issues/12143#issuecomment-17134659=
81
>>> [2]: https://3v4l.org/3Q7BC
>
> If this can be considered a bug fix, then I'm in favor of keeping it as =
is. (I wasn't sure if this should be considered a feature addition.)

Well, if I call round() and tell it to round to zero decimals, and it
doesn't do it (assuming precision=3D-1), that looks like a bug to me.

> I will update UPGRADING with concrete examples.

Thank you!

Cheers,
Christoph