Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124352
Precedence: bulk
MIME-Version: 1.0
References: <CA+XhMqyeqkzDTYygnKm+sr9K3Yfv0b5znM27RfwTVN8oaDZ6JQ@mail.gmail.com>
 <67DDAB86-18E9-4C89-B1DA-CE8FC1E927F9@sakiot.com> <CA+XhMqx6kGSdR=uVitmLoJB9MV5_PXSi3f=SkTTK5QEaPzfHcg@mail.gmail.com>
 <ab99d7aa-a711-48e1-8d78-322ba1a78e7d@bastelstu.be>
In-Reply-To: <ab99d7aa-a711-48e1-8d78-322ba1a78e7d@bastelstu.be>
Date: Wed, 10 Jul 2024 16:24:04 +0100
Message-ID: <CA+XhMqyi=dta3MoePRHgW2ho+x90JUWh606mNXO03bs=67r4dg@mail.gmail.com>
Subject: Re: [PHP-DEV] ext/gd adding imagecompare
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: Saki Takamachi <saki@sakiot.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000044a1b6061ce63d8a"
From: devnexen@gmail.com (David CARLIER)

--00000000000044a1b6061ce63d8a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi

On Tue, 9 Jul 2024 at 19:16, Tim D=C3=BCsterhus <tim@bastelstu.be> wrote:

> Hi
>
> On 7/9/24 19:53, David CARLIER wrote:
> > Agreed, I ll likely just commit as is sometime this week.
>
> I hereby formally claim that this is not a simple self-contained
> feature. It does require an RFC.
>
> The addition of global `IMAGE_CMP_*` constants effectively introduces an
> entirely new "namespace" within the existing list of constants and thus
> I do not believe that consistency with the existing GD functionality is
> a valid reason. As such I believe they should follow the
> https://wiki.php.net/rfc/namespaces_in_bundled_extensions RFC and be
> placed inside the `Gd` namespace - or ideally be replaced by a proper
> enum or so.
>
> Best regards
> Tim D=C3=BCsterhus
>

Alright, I hear you. Anyhow, there is a debate for having a full internal
version of a somewhat similar feature. We will see..

--00000000000044a1b6061ce63d8a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi</div><br><div class=3D"gmail_quote"><d=
iv dir=3D"ltr" class=3D"gmail_attr">On Tue, 9 Jul 2024 at 19:16, Tim D=C3=
=BCsterhus &lt;<a href=3D"mailto:tim@bastelstu.be">tim@bastelstu.be</a>&gt;=
 wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px =
0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi<br>
<br>
On 7/9/24 19:53, David CARLIER wrote:<br>
&gt; Agreed, I ll likely just commit as is sometime this week.<br>
<br>
I hereby formally claim that this is not a simple self-contained <br>
feature. It does require an RFC.<br>
<br>
The addition of global `IMAGE_CMP_*` constants effectively introduces an <b=
r>
entirely new &quot;namespace&quot; within the existing list of constants an=
d thus <br>
I do not believe that consistency with the existing GD functionality is <br=
>
a valid reason. As such I believe they should follow the <br>
<a href=3D"https://wiki.php.net/rfc/namespaces_in_bundled_extensions" rel=
=3D"noreferrer" target=3D"_blank">https://wiki.php.net/rfc/namespaces_in_bu=
ndled_extensions</a> RFC and be <br>
placed inside the `Gd` namespace - or ideally be replaced by a proper <br>
enum or so.<br>
<br>
Best regards<br>
Tim D=C3=BCsterhus<br></blockquote><div><br></div><div>Alright, I hear you.=
 Anyhow, there is a debate for having a full internal version of a somewhat=
 similar feature. We will see..</div></div></div>

--00000000000044a1b6061ce63d8a--