Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124346
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-568-g843fbadbe-fm-20240701.003-g843fbadb
Precedence: bulk
MIME-Version: 1.0
Message-ID: <b3bfc8be-5aad-4f4a-b6cd-2d49d77220bd@app.fastmail.com>
In-Reply-To: <fbf45a9a-0385-4c42-a6a0-4f3ee1c8728d@app.fastmail.com>
References: <fbf45a9a-0385-4c42-a6a0-4f3ee1c8728d@app.fastmail.com>
Date: Wed, 10 Jul 2024 08:47:14 -0500
To: "php internals" <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] Property Hook improvements
Content-Type: text/plain
From: larry@garfieldtech.com ("Larry Garfield")

On Mon, Jul 1, 2024, at 12:02 PM, Larry Garfield wrote:
> Hi folks.  As Ilija's been polishing off hooks to get the PR merged, 
> we've run into two small revisions that should make life better for all 
> involved.  One is a performance improvement that requires a very slight 
> error handling behavior change, and the other is enabling readonly in 
> selected (but probably all of the relevant) circumstances.
>
> I'd say we expect these to be uncontroversial, but this is PHP. :-)  So 
> I will instead just note that it's a short RFC and open the discussion 
> accordingly.
>
> https://wiki.php.net/rfc/hook_improvements

Based on discussion here and off-list, and after confirming with Nicolas that lazy objects would be compatible with readonly properties already (which have very similar use cases in practice), we're going to hold off on the readonly hooks part of this RFC.  I've split it off to its own RFC for later:

https://wiki.php.net/rfc/readonly_hooks

The other half of this RFC, removing the recursion guard in return for performance, has had no objections.  Its discussion period ends Friday, so I will open the vote on that Monday-ish.

--Larry Garfield