Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124336
Date: Wed, 10 Jul 2024 10:07:55 +0100 (BST)
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
cc: Saki Takamachi <saki@sakiot.com>, 
    Juliette Reinders Folmer <php-internals_nospam@adviesenzo.nl>, 
    php internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Allow int type argument to BCMath
 function
In-Reply-To: <2a58f11d-ee93-42b9-825c-18cd490b9dc5@bastelstu.be>
Message-ID: <25859f24-8886-e4fe-5321-fae5140abf4a@php.net>
References: <668B4C78.2000808@adviesenzo.nl> <8FA0DE3B-2AF4-4110-9836-14E035DC8169@sakiot.com> <668B6428.9030705@adviesenzo.nl> <3DF46B77-530C-4CC7-8BFF-8B3DC2232EE2@sakiot.com> <2a58f11d-ee93-42b9-825c-18cd490b9dc5@bastelstu.be>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-261432467-1720602477=:3691"
From: derick@php.net (Derick Rethans)

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-261432467-1720602477=:3691
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Tue, 9 Jul 2024, Tim D=C3=BCsterhus wrote:

> On 7/8/24 06:29, Saki Takamachi wrote:
>
> > I don't think a satisfactory specification will be decided on this=20
> > before the feature freeze, so I will not rush into discussing this=20
> > RFC for now. Of course, no voting will take place until the=20
> > specifications are decided. If we were to discuss this change again,=20
> > it would be in versions beyond 8.4.
>=20
> I agree with Juliette that as long as passing a non-integer float to=20
> an int parameter is only a deprecation warning, widening the signature=20
> to `string|int` is too much of a breaking change.

I agree too, and don't think we should change this in PHP 8.x.

and probably would also question:

"bcfloor() and bcceil() are excluded because there is no point in=20
allowing int type arguments due to the characteristics of their=20
functions. "

Although that is right, having these *also* accept ints would at least=20
be consistent.

cheers,
Derick
--8323329-261432467-1720602477=:3691--