Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124334
Date: Wed, 10 Jul 2024 09:55:01 +0100 (BST)
To: Saki Takamachi <saki@sakiot.com>
cc: Rob Landers <rob@bottled.codes>, internals@lists.php.net
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add bcdivmod to BCMath
In-Reply-To: <3B23E039-D90F-4F84-9ECE-C6A9A3E145AF@sakiot.com>
Message-ID: <78a15506-65c5-e29e-86a9-32e921ae9dd5@php.net>
References: <F709ADD3-502E-418B-82D3-34A681EBB7A0@sakiot.com> <668168A7.4040005@adviesenzo.nl> <e4a3fba1-e441-4f35-ac17-462f5f9c3fb9@app.fastmail.com> <3B23E039-D90F-4F84-9ECE-C6A9A3E145AF@sakiot.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-262714967-1720601613=:3691"
From: derick@php.net (Derick Rethans)

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-262714967-1720601613=:3691
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Mon, 1 Jul 2024, Saki Takamachi wrote:

> Hi,
>=20
> >> Just a suggestion: what about making the returned array an associative
> >> array ? Like so:
> >> ```
> >> array(
> >>      'quotient' =3D> 61,
> >>      'remainder' =3D> 1,
> >> );
> >> ```
> >> This would remove the need for devs to remember the order of the retur=
n
> >> values and would make the return value self-documenting.
> >=20
> > An associative array would combine the worst of an array (no IDE autoco=
mpletion, no strong typing, increased memory usage) with the worst of an ob=
ject (no easy way to extract the values into local variables with array des=
tructuring).
> >=20
> > The example in the RFC doesn't show it, but the following makes the pro=
posed API really convenient to use:
> >=20
> >    $slicesOfPizza =3D new BcMath\Number(8);
> >    $mouthsToFeed =3D new BcMath\Number(3);
> >    [$perMouth, $slicesLeft] =3D $slicesOfPizza->divmod($mouthsToFeed);
> >=20
> > Note how the order of values matches the words in the method name. Firs=
t the result of 'div', then the result of 'mod=E2=80=99.
>=20
>=20
> Thanks, I have added this example to the RFC (Please let me know if you h=
ave any problems).

The example has:

=09[$perMouth, $slicesLeft] =3D $slicesOfPizza->divmod($mouthsToFeed);
=09=20
=09// $perMouth->value is '2'
=09// $slicesLeft->value is '2'

Shouldn't that be (without the ->value) ?

=09[$perMouth, $slicesLeft] =3D $slicesOfPizza->divmod($mouthsToFeed);
=09=20
=09// $perMouth is '2'
=09// $slicesLeft is '2'

cheers,
Derick
--8323329-262714967-1720601613=:3691--