Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124325
Date: Tue, 09 Jul 2024 23:39:37 +0000
To: "Gina P. Banyard" <internals@gpb.moe>
Cc: PHP internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] Improve language coherence for the behaviour of offsets and containers
Message-ID: <EE-aMte3i-_DTmSrqDgoaRPATmjLUcLt-k31baT8lqqCsrzIy0UsOyKo9rlBs51gWKUK7e7X3VYDuJmxhd6bxOGe52k8ITQgoN0_AE0RnoY=@gpb.moe>
In-Reply-To: <mhbeurk_htxbQxzIEs98wQoR8Xczf-L7L8aCAIVhATD7wQiEUJwpAYxYS-llyac0pN761mnQJfpVQcDUoXAgasaWpWylpt6LE-I2oM4zrbk=@gpb.moe>
References: <mhbeurk_htxbQxzIEs98wQoR8Xczf-L7L8aCAIVhATD7wQiEUJwpAYxYS-llyac0pN761mnQJfpVQcDUoXAgasaWpWylpt6LE-I2oM4zrbk=@gpb.moe>
Feedback-ID: 96993444:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: internals@gpb.moe ("Gina P. Banyard")

On Thursday, 4 July 2024 at 14:52, Gina P. Banyard <internals@gpb.moe> wrot=
e:

> Hello internals,
>=20
> I would like to formally open the discussion on an RFC I've been working =
on for the past year:
> https://wiki.php.net/rfc/container-offset-behaviour
>=20
> As DokuWiki is a bit of a faff at times, the Markdown sources are availab=
le on GitHub:
> https://github.com/Girgias/php-rfcs/blob/master/container-offset-behaviou=
r.md

I have more or less finalized the implementation of the object handler part=
.
The JIT works, and my minimal opcache changes seem to not make everything c=
rash.

I have added one tiny subsection to the RFC about the removal of the zend_c=
lass_arrayaccess_funcs struct:
https://wiki.php.net/rfc/container-offset-behaviour#removal_of_the_zend_cla=
ss_arrayaccess_funcs_struct_and_ce_pointer

One related issue that I found while working on this RFC is related to ext/=
phar:
https://github.com/php/php-src/pull/14503

A PharFileInfo extends SplFileInfo and supports directories, which SplFileI=
nfo does not.
But Phar also allows the user to set the file info class via the setInfoCla=
ss() method.
This method takes any SplFileInfo based class, such as SplFileObject.
Thus, there is currently a bug in the extension where isset() will return t=
rue about being able to access a string offset that points to a directory b=
ut SplFileObject will throw a LogicException that it cannot be used with a =
directory.

There are two-way to fix this issue, in my PR I went with the solution to r=
eturn false for the has_dimension handler on directories if the info class =
is not based on PharFileInfo,
or we could remove support for setting info classes that are not based on P=
harFileInfo.

Let me know what you prefer, as my current implementation is based on the a=
bove PR to fix the Phar behavioural changes.

Moreover, I know the traffic on the list has been pretty high, but I do int=
end to have this RFC up for voting for inclusion in PHP 8.4, and I'm not ex=
actly sure how I am meant to interpret the lack of responses.

Best regards,

Gina P. Banyard