Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:124319 X-Original-To: internals@lists.php.net Delivered-To: internals@lists.php.net Received: from php-smtp4.php.net (php-smtp4.php.net [45.112.84.5]) by qa.php.net (Postfix) with ESMTPS id 9AE6A1A00B7 for ; Tue, 9 Jul 2024 18:16:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=php.net; s=mail; t=1720549072; bh=T65K4fNMHXHwbzr/MBF+dUTEahZ7DKf+TG2efGrqFmA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=AgoFKUD16oTprwNFej2STMxf1llf4I7UCqz9owimYHeMsVYUEq2wm4TO8cpRciKxh iy6NORgIACQxrT5mabm2Vd22WwTVJapdRZjFma2ik4EXj64MGcjXYN3YIwFJA5EWiF iCPFxbZl0oEBt57BPI9nnz/kHC4EVgKXFUzj2SlvcqoUIpyOgrIC9daB50Yyc7jdCW 6SA0z91EvPO1QmfLE1lj+sUmHnpcEtkvVcd6gB0YT2f39r0Ded15GnjfZwlB7Qng6H 1knztyWb37BFQw6ak5nHgE3lQLuOW+pC7WBQ8qcAW+nNYGe4tudTV9Ta9FFNu2w8Ni Fp/KSXqkbYoIw== Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 529CE180D8B for ; Tue, 9 Jul 2024 18:17:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_50,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,DMARC_PASS,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=4.0.0 X-Spam-Virus: No X-Envelope-From: Received: from chrono.xqk7.com (chrono.xqk7.com [176.9.45.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Tue, 9 Jul 2024 18:17:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bastelstu.be; s=mail20171119; t=1720548985; bh=pef5gNShg10bLKDuxRYResyJD441GXZkcTyuQs2SO40=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type:from:to:cc:subject:message-id; b=kmyBw7g+zwo8uRyvi3SJYh8YT8bxZYg3AlHt1o+6fwV+JzYObA79Z4sV1b1FqXm5n 51+tB20dP12/ig9wtFkFEejOafh5txAOarUcPhhqwWiiZjtuM+3VWUoDL1XGYbKzwf KV47kO1KkyUESOVN838X7ymkxVghm/sy5dRuPLRWPAr4BQmBAt4aBLJJtsvh6eulh4 YrHMbQ3IIIhP5rbY/HEldk3BOd94IFBJ2R27c5z6N/1S0/P2c1dnD0HxUwNs3qGP6w nCr6+LEzvonde7fqYXjGbpqxMTnHmPm+hQX9rGrf9FcUTzyc9m8GdYQA8x2pCe7Rfv MN5lglZVAz/6g== Message-ID: Date: Tue, 9 Jul 2024 20:16:23 +0200 Precedence: bulk list-help: list-post: List-Id: internals.lists.php.net MIME-Version: 1.0 Subject: Re: [PHP-DEV] ext/gd adding imagecompare To: David CARLIER , Saki Takamachi Cc: PHP internals References: <67DDAB86-18E9-4C89-B1DA-CE8FC1E927F9@sakiot.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=) Hi On 7/9/24 19:53, David CARLIER wrote: > Agreed, I ll likely just commit as is sometime this week. I hereby formally claim that this is not a simple self-contained feature. It does require an RFC. The addition of global `IMAGE_CMP_*` constants effectively introduces an entirely new "namespace" within the existing list of constants and thus I do not believe that consistency with the existing GD functionality is a valid reason. As such I believe they should follow the https://wiki.php.net/rfc/namespaces_in_bundled_extensions RFC and be placed inside the `Gd` namespace - or ideally be replaced by a proper enum or so. Best regards Tim Düsterhus