Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124318
Message-ID: <1a03ee20-ebc3-4406-abaf-9e939bffa784@bastelstu.be>
Date: Tue, 9 Jul 2024 20:05:58 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] ext/gd adding imagecompare
To: Kamil Tekiela <tekiela246@gmail.com>, David CARLIER <devnexen@gmail.com>
Cc: PHP internals <internals@lists.php.net>
References: <CA+XhMqxc3O-b6aozMkh6kdH2QEa1yVTkdXj7vO82d36rgXt4Ag@mail.gmail.com>
 <CAGBsUrfW8kj208ikUiipmAXVvkmEARTeEgU0AAqqBi38P3UufQ@mail.gmail.com>
Content-Language: en-US
In-Reply-To: <CAGBsUrfW8kj208ikUiipmAXVvkmEARTeEgU0AAqqBi38P3UufQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

Yes, please no more global constants with names that are shortened 
beyond all recognition.

On 7/9/24 18:59, Kamil Tekiela wrote:
> Boolean is a much more confusing value here. A bit mask is ok, but I would
> prefer a better solution. Maybe a simple value object?
> 

If it's "simple" then it would also be unwieldy to use. To me the 
obvious modern alternative would be a list of enum cases that represent 
the differences, with an empty array meaning no differences. The 
function should probably be renamed 'imagediff()' or similar then.

     namespace Gd;

     enum ImageDifference {
         case Height;
         case Width;
         case AlphaChannel; // or: case Transparency
         case Interlacing;
         // ...
     }

Best regards
Tim Düsterhus