Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124317
Precedence: bulk
MIME-Version: 1.0
References: <CA+XhMqyeqkzDTYygnKm+sr9K3Yfv0b5znM27RfwTVN8oaDZ6JQ@mail.gmail.com>
 <67DDAB86-18E9-4C89-B1DA-CE8FC1E927F9@sakiot.com>
In-Reply-To: <67DDAB86-18E9-4C89-B1DA-CE8FC1E927F9@sakiot.com>
Date: Tue, 9 Jul 2024 18:53:38 +0100
Message-ID: <CA+XhMqx6kGSdR=uVitmLoJB9MV5_PXSi3f=SkTTK5QEaPzfHcg@mail.gmail.com>
Subject: Re: [PHP-DEV] ext/gd adding imagecompare
To: Saki Takamachi <saki@sakiot.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000004cc896061cd436a5"
From: devnexen@gmail.com (David CARLIER)

--0000000000004cc896061cd436a5
Content-Type: text/plain; charset="UTF-8"

On Tue, 9 Jul 2024 at 18:31, Saki Takamachi <saki@sakiot.com> wrote:

> Hi David,
>
> It seems to be the opposite regarding his proposition gdImageCompare(im1,
> im2) & GD_CMP_IMAGE. Then yes you are right, we are losing the specifics.
> If you want to figure out how the image 1 and image 2 differ, you need to
> use the rest of the api e.g. imagecolortransparent and all that jazz ... A
> bit too complex I feel.
>
>
> Thanks for the explanation.
>
> What I think is important to note here is that there are two types of
> users who will use this feature:
>
> 1. Users who simply want to know if there is a match (i.e. a bool return
> value is sufficient)
>

True. Anyhow, such users can always do imagecompare($im1, $im2) &
IMG_CMP_IMAGE themselves eventually.

> 2. Users who want to know the details of the differences
>
> The object return type that Kamil mentioned was something I was
> considering as well, but I was concerned that it would be a bit verbose for
> type 1 users and would necessarily incur the overhead of object creation.
> (This is probably an unnecessary concern, as image analysis takes much
> longer.)
>

Agreed, I ll likely just commit as is sometime this week.
Cheers.

>
> Regards,
>
> Saki
>

--0000000000004cc896061cd436a5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Tue, 9 Jul 2024 at 18:31, Saki Tak=
amachi &lt;<a href=3D"mailto:saki@sakiot.com">saki@sakiot.com</a>&gt; wrote=
:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.=
8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"au=
to"><div dir=3D"ltr"></div><div dir=3D"ltr">Hi David,</div><div dir=3D"ltr"=
><br></div><blockquote type=3D"cite"><div dir=3D"ltr"><div>It seems to be t=
he opposite regarding his proposition=C2=A0<span style=3D"background-color:=
rgba(175,184,193,0.2);color:rgb(31,35,40);font-family:ui-monospace,SFMono-R=
egular,&quot;SF Mono&quot;,Menlo,Consolas,&quot;Liberation Mono&quot;,monos=
pace;font-size:11.9px">gdImageCompare(im1, im2) &amp; GD_CMP_IMAGE</span><s=
pan style=3D"color:rgb(31,35,40);background-color:rgb(255,255,255)"><font f=
ace=3D"arial, sans-serif">. Then yes you are right, we are losing the speci=
fics. If you want to figure out how the image 1 and image 2 differ, you nee=
d to use the rest of the api e.g. imagecolortransparent and all that jazz .=
.. A bit too complex I feel.</font></span></div></div></blockquote><br><div=
>Thanks for the explanation.</div><div><br></div><div>What I think is impor=
tant to note here is that there are two types of users who will use this fe=
ature:</div><div><br></div><div>1. Users who simply want to know if there i=
s a match (i.e. a bool return value is sufficient)</div></div></blockquote>=
<div><br></div><div>True. Anyhow, such users can always do imagecompare($im=
1, $im2) &amp; IMG_CMP_IMAGE themselves eventually.=C2=A0</div><blockquote =
class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px sol=
id rgb(204,204,204);padding-left:1ex"><div dir=3D"auto"><div>2. Users who w=
ant to know the details of the differences</div><div><br></div><div>The obj=
ect return type that Kamil mentioned was something I was considering as wel=
l, but I was concerned that it would be a bit verbose for type 1 users and =
would necessarily incur the overhead of object creation. (This is probably =
an unnecessary concern, as image analysis takes much longer.)</div></div></=
blockquote><div><br></div><div>Agreed, I ll likely just commit as is someti=
me this week.</div><div>Cheers.=C2=A0</div><blockquote class=3D"gmail_quote=
" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);=
padding-left:1ex"><div dir=3D"auto"><div><br></div><div>Regards,</div><div>=
<br></div><div>Saki</div></div></blockquote></div></div>

--0000000000004cc896061cd436a5--