Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124316
Message-ID: <2a58f11d-ee93-42b9-825c-18cd490b9dc5@bastelstu.be>
Date: Tue, 9 Jul 2024 19:50:54 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] [RFC] [Discussion] Allow int type argument to BCMath
 function
To: Saki Takamachi <saki@sakiot.com>,
 Juliette Reinders Folmer <php-internals_nospam@adviesenzo.nl>
Cc: php internals <internals@lists.php.net>
References: <668B4C78.2000808@adviesenzo.nl>
 <8FA0DE3B-2AF4-4110-9836-14E035DC8169@sakiot.com>
 <668B6428.9030705@adviesenzo.nl>
 <3DF46B77-530C-4CC7-8BFF-8B3DC2232EE2@sakiot.com>
Content-Language: en-US
In-Reply-To: <3DF46B77-530C-4CC7-8BFF-8B3DC2232EE2@sakiot.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 7/8/24 06:29, Saki Takamachi wrote:
> I don't think a satisfactory specification will be decided on this before the feature freeze, so I will not rush into discussing this RFC for now. Of course, no voting will take place until the specifications are decided. If we were to discuss this change again, it would be in versions beyond 8.4.

I agree with Juliette that as long as passing a non-integer float to an 
int parameter is only a deprecation warning, widening the signature to 
`string|int` is too much of a breaking change.

Given that once you called a BCMath function the output is a string, the 
int->string conversion would only happen at the inputs. The performance 
cost should be fully acceptable and this looks like a premature 
micro-optimization.

Best regards
Tim Düsterhus