Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124313
Content-Type: multipart/alternative; boundary=Apple-Mail-E314D3DA-FD96-4CB6-B6FB-81CC0C45F04B
Content-Transfer-Encoding: 7bit
Precedence: bulk
Mime-Version: 1.0 (1.0)
Subject: Re: [PHP-DEV] ext/gd adding imagecompare
Date: Wed, 10 Jul 2024 02:31:30 +0900
Message-ID: <67DDAB86-18E9-4C89-B1DA-CE8FC1E927F9@sakiot.com>
References: <CA+XhMqyeqkzDTYygnKm+sr9K3Yfv0b5znM27RfwTVN8oaDZ6JQ@mail.gmail.com>
Cc: PHP internals <internals@lists.php.net>
In-Reply-To: <CA+XhMqyeqkzDTYygnKm+sr9K3Yfv0b5znM27RfwTVN8oaDZ6JQ@mail.gmail.com>
To: David CARLIER <devnexen@gmail.com>
From: saki@sakiot.com (Saki Takamachi)


--Apple-Mail-E314D3DA-FD96-4CB6-B6FB-81CC0C45F04B
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable

Hi David,

> It seems to be the opposite regarding his proposition gdImageCompare(im1, i=
m2) & GD_CMP_IMAGE. Then yes you are right, we are losing the specifics. If y=
ou want to figure out how the image 1 and image 2 differ, you need to use th=
e rest of the api e.g. imagecolortransparent and all that jazz ... A bit too=
 complex I feel.

Thanks for the explanation.

What I think is important to note here is that there are two types of users w=
ho will use this feature:

1. Users who simply want to know if there is a match (i.e. a bool return val=
ue is sufficient)
2. Users who want to know the details of the differences

The object return type that Kamil mentioned was something I was considering a=
s well, but I was concerned that it would be a bit verbose for type 1 users a=
nd would necessarily incur the overhead of object creation. (This is probabl=
y an unnecessary concern, as image analysis takes much longer.)

Regards,

Saki=

--Apple-Mail-E314D3DA-FD96-4CB6-B6FB-81CC0C45F04B
Content-Type: text/html;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; charset=3D=
utf-8"></head><body dir=3D"auto"><div dir=3D"ltr"></div><div dir=3D"ltr">Hi D=
avid,</div><div dir=3D"ltr"><br></div><blockquote type=3D"cite"><div dir=3D"=
ltr"><div>It seems to be the opposite regarding his proposition&nbsp;<span s=
tyle=3D"background-color:rgba(175,184,193,0.2);color:rgb(31,35,40);font-fami=
ly:ui-monospace,SFMono-Regular,&quot;SF Mono&quot;,Menlo,Consolas,&quot;Libe=
ration Mono&quot;,monospace;font-size:11.9px">gdImageCompare(im1, im2) &amp;=
 GD_CMP_IMAGE</span><span style=3D"color:rgb(31,35,40);background-color:rgb(=
255,255,255)"><font face=3D"arial, sans-serif" style=3D"">. Then yes you are=
 right, we are losing the specifics. If you want to figure out how the image=
 1 and image 2 differ, you need to use the rest of the api e.g. imagecolortr=
ansparent and all that jazz ... A bit too complex I feel.</font></span></div=
></div></blockquote><br><div>Thanks for the explanation.</div><div><br></div=
><div>What I think is important to note here is that there are two types of u=
sers who will use this feature:</div><div><br></div><div>1. Users who simply=
 want to know if there is a match (i.e. a bool return value is sufficient)</=
div><div>2. Users who want to know the details of the differences</div><div>=
<br></div><div>The object return type that Kamil mentioned was something I w=
as considering as well, but I was concerned that it would be a bit verbose f=
or type 1 users and would necessarily incur the overhead of object creation.=
 (This is probably an unnecessary concern, as image analysis takes much long=
er.)</div><div><br></div><div>Regards,</div><div><br></div><div>Saki</div></=
body></html>=

--Apple-Mail-E314D3DA-FD96-4CB6-B6FB-81CC0C45F04B--