Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124310
Precedence: bulk
MIME-Version: 1.0
References: <CA+XhMqxc3O-b6aozMkh6kdH2QEa1yVTkdXj7vO82d36rgXt4Ag@mail.gmail.com>
 <3CA7F710-D305-497D-910D-320372A61A6C@sakiot.com>
In-Reply-To: <3CA7F710-D305-497D-910D-320372A61A6C@sakiot.com>
Date: Tue, 9 Jul 2024 18:09:26 +0100
Message-ID: <CA+XhMqyeqkzDTYygnKm+sr9K3Yfv0b5znM27RfwTVN8oaDZ6JQ@mail.gmail.com>
Subject: Re: [PHP-DEV] ext/gd adding imagecompare
To: Saki Takamachi <saki@sakiot.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000049aed8061cd3983a"
From: devnexen@gmail.com (David CARLIER)

--00000000000049aed8061cd3983a
Content-Type: text/plain; charset="UTF-8"

Hi Saki.

On Tue, 9 Jul 2024 at 17:49, Saki Takamachi <saki@sakiot.com> wrote:

> Hi David,
>
> > Hi,
> >
> > I plan to add imagecompare to the gd extension. No problem so far
> however a little discussion of the returned value
> >
> > https://github.com/php/php-src/pull/14877#issuecomment-2217686123
> >
> > I personally see a value of a bitmask rather than just boolean which is
> not harder to handle than imagetypes.
> >
> > Let me know your thoughts.
> >
> > Cheers.
>
> If the return value is bool, does this mean that it will be true if the
> comparison targets are exactly the same, and false if there is even one
> difference? In other words, will we no longer be able to see where the
> differences were?
>
>
It seems to be the opposite regarding his proposition gdImageCompare(im1,
im2) & GD_CMP_IMAGE. Then yes you are right, we are losing the specifics.
If you want to figure out how the image 1 and image 2 differ, you need to
use the rest of the api e.g. imagecolortransparent and all that jazz ... A
bit too complex I feel.


> Regards,
>
> Saki

--00000000000049aed8061cd3983a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi Saki.</div><br><div class=3D"gmail_quote"><div dir=
=3D"ltr" class=3D"gmail_attr">On Tue, 9 Jul 2024 at 17:49, Saki Takamachi &=
lt;<a href=3D"mailto:saki@sakiot.com">saki@sakiot.com</a>&gt; wrote:<br></d=
iv><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bord=
er-left:1px solid rgb(204,204,204);padding-left:1ex">Hi David,<br>
<br>
&gt; Hi,<br>
&gt; <br>
&gt; I plan to add imagecompare to the gd extension. No problem so far howe=
ver a little discussion of the returned value<br>
&gt; <br>
&gt; <a href=3D"https://github.com/php/php-src/pull/14877#issuecomment-2217=
686123" rel=3D"noreferrer" target=3D"_blank">https://github.com/php/php-src=
/pull/14877#issuecomment-2217686123</a><br>
&gt; <br>
&gt; I personally see a value of a bitmask rather than just boolean which i=
s not harder to handle than imagetypes.<br>
&gt; <br>
&gt; Let me know your thoughts.<br>
&gt; <br>
&gt; Cheers.<br>
<br>
If the return value is bool, does this mean that it will be true if the com=
parison targets are exactly the same, and false if there is even one differ=
ence? In other words, will we no longer be able to see where the difference=
s were?<br>
<br></blockquote><div><br></div><div>It seems to be the opposite regarding =
his proposition=C2=A0<span style=3D"background-color:rgba(175,184,193,0.2);=
color:rgb(31,35,40);font-family:ui-monospace,SFMono-Regular,&quot;SF Mono&q=
uot;,Menlo,Consolas,&quot;Liberation Mono&quot;,monospace;font-size:11.9px"=
>gdImageCompare(im1, im2) &amp; GD_CMP_IMAGE</span><span style=3D"color:rgb=
(31,35,40);background-color:rgb(255,255,255)"><font face=3D"arial, sans-ser=
if" style=3D"">. Then yes you are right, we are losing the specifics. If yo=
u want to figure out how the image 1 and image 2 differ, you need to use th=
e rest of the api e.g. imagecolortransparent and all that jazz ... A bit to=
o complex I feel.</font></span></div><div>=C2=A0</div><blockquote class=3D"=
gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(20=
4,204,204);padding-left:1ex">
Regards,<br>
<br>
Saki</blockquote></div></div>

--00000000000049aed8061cd3983a--