Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:124307 X-Original-To: internals@lists.php.net Delivered-To: internals@lists.php.net Received: from php-smtp4.php.net (php-smtp4.php.net [45.112.84.5]) by qa.php.net (Postfix) with ESMTPS id 143E81A00B7 for ; Tue, 9 Jul 2024 16:49:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=php.net; s=mail; t=1720543847; bh=3KmrO0+JywrFzWuTcytBL+cxnoRCLodOUv/pSJ7HVBE=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=H+3XMBbMQkSCrhLcoX34J3Dw/69SsSxo4osLnzgIREse+GeRy6DlKnfQy2tG1iF+Z 7bZ/U/k1umnVgILJ/QUPg3H5tCwv/nZ57VIF2RgzCiOYu+e3Iaxqnqbll70LANoSgN rFrvpsZvPBtknkys768KAi5U3N+AyCNLeErgLWCAJCCpspmdBdGQYtSVoRzB8iheiI It1D6xSItpQI5LV7/vFmRu+Ul1fhBG+7lcb7kOzX+/9r/xdhqpYc+5AXK8U6gm4Bws uuWfFcnWNERmjnFbPdkkb7qougaFYeJBLG9Solp4J8FDH1uTNLl7JNbb7yXtfkDF4F /OurcBPEklFsQ== Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id BF6DC1805C1 for ; Tue, 9 Jul 2024 16:50:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_50,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,DMARC_PASS,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=4.0.0 X-Spam-Virus: No X-Envelope-From: Received: from mail.sakiot.com (mail.sakiot.com [160.16.227.216]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Tue, 9 Jul 2024 16:50:45 +0000 (UTC) Received: from smtpclient.apple (unknown [117.55.37.250]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.sakiot.com (Postfix) with ESMTPSA id B443B4011C; Wed, 10 Jul 2024 01:49:16 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sakiot.com; s=default; t=1720543756; bh=3KmrO0+JywrFzWuTcytBL+cxnoRCLodOUv/pSJ7HVBE=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=nkdRRxB6bA3+I23jijADcOzqSox7lWanMH/3e5iLtbq3Mgr/MW4xRH1uWuzz1zRbM 3r2x1etOX41F289Rb+O3n0pJqZSS3XjCt386+diPbiNraus4nqfc16U/ZEdOGAv2j6 0eeaImMU6YrHRgDwS6FgT9oYh/ItQBRDS7eBqGUA= Content-Type: text/plain; charset=us-ascii Precedence: bulk list-help: list-post: List-Id: internals.lists.php.net Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Subject: Re: [PHP-DEV] ext/gd adding imagecompare In-Reply-To: Date: Wed, 10 Jul 2024 01:49:03 +0900 Cc: PHP internals Content-Transfer-Encoding: quoted-printable Message-ID: <3CA7F710-D305-497D-910D-320372A61A6C@sakiot.com> References: To: David CARLIER X-Mailer: Apple Mail (2.3774.600.62) From: saki@sakiot.com (Saki Takamachi) Hi David, > Hi, >=20 > I plan to add imagecompare to the gd extension. No problem so far = however a little discussion of the returned value >=20 > https://github.com/php/php-src/pull/14877#issuecomment-2217686123 >=20 > I personally see a value of a bitmask rather than just boolean which = is not harder to handle than imagetypes. >=20 > Let me know your thoughts. >=20 > Cheers. If the return value is bool, does this mean that it will be true if the = comparison targets are exactly the same, and false if there is even one = difference? In other words, will we no longer be able to see where the = differences were? Regards, Saki=