Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124285
Message-ID: <46b52327-ec2c-4aa4-bab2-a7d6c64f10be@gmail.com>
Date: Mon, 8 Jul 2024 13:27:50 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] [RFC] Deprecations for PHP 8.4
To: internals@lists.php.net
References: <bw20I5b7ly3lSbI-2Bv3kfrfTVJbDo5RhwBiQa1PEwuLjprDJWptPajLiaialj1RLVKu7z1j0MofJUhhRVtzT_5i2E11oKeQx_VMUxnKhUE=@gpb.moe>
 <76838718-E108-4A08-A88F-4965FB81E52C@gmail.com>
 <zbaR883eiuuR-PG4cLEnScro-OhJd-cvYHOESr1edYKRZAb8PpUeGya4X656x1jmY5WzNXbHZA2hNP2L5RWT0wUn7KjhpUMNf9TaXg1ZIqo=@gpb.moe>
Content-Language: en-US
In-Reply-To: <zbaR883eiuuR-PG4cLEnScro-OhJd-cvYHOESr1edYKRZAb8PpUeGya4X656x1jmY5WzNXbHZA2hNP2L5RWT0wUn7KjhpUMNf9TaXg1ZIqo=@gpb.moe>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: dossche.niels@gmail.com (Niels Dossche)

On 08/07/2024 01:12, Gina P. Banyard wrote:
> On Friday, 5 July 2024 at 18:11, Claude Pache <claude.pache@gmail.com> wrote:
>> * I don’t see the point of deprecating DOMImplementation::getFeature() instead of just removing it? “DOMImplementation::getFeature() is deprecated, throw manually an Error exception instead.”
> 
> Just removing it makes sense, I'll talk to Niels about it, to change what the vote is actually about.

The reason I put it on deprecation instead of removal was because I thought we always had to go through deprecation first before we could remove things.
Gina and I talked and we concluded that we could just remove it indeed, as this method always threw an exception anyway due to it being unimplemented.
I'll update the RFC.

Kind regards
Niels