Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124277
Subject: Re: [PHP-DEV] [RFC] Deprecations for PHP 8.4
To: internals@lists.php.net
References: <bw20I5b7ly3lSbI-2Bv3kfrfTVJbDo5RhwBiQa1PEwuLjprDJWptPajLiaialj1RLVKu7z1j0MofJUhhRVtzT_5i2E11oKeQx_VMUxnKhUE=@gpb.moe>
 <6683CDE4.7050607@adviesenzo.nl>
 <Skh-IB3l7OxslclNZdB5ZE3G5PaIvpoz3iojK10noNbXkj1odNNvzI5w7X1aSj7IKZ951646yQ8IrUW_wNaQuv94NB0jo3IXlFImcpu_hxc=@gpb.moe>
 <668B5728.40300@adviesenzo.nl>
 <4cf169f4-e222-4140-aef7-20eb5b871d32@heigl.org>
Message-ID: <668B73B6.7070509@adviesenzo.nl>
Date: Mon, 8 Jul 2024 07:05:58 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <4cf169f4-e222-4140-aef7-20eb5b871d32@heigl.org>
Content-Type: multipart/alternative;
 boundary="------------020008000405050606010805"
From: php-internals_nospam@adviesenzo.nl (Juliette Reinders Folmer)

This is a multi-part message in MIME format.
--------------020008000405050606010805
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

On 8-7-2024 6:57, Andreas Heigl wrote:
>
>
> Am 08.07.24 um 05:04 schrieb Juliette Reinders Folmer:
> [...]
>>
>> I also don't agree that there are "more appropriate replacements 
>> available".
>> The  suggested `hash()` replacements for the md5/sha1* functions have 
>> the exact same functionality, which the RFC considers "incorrect 
>> use", so what are we actually solving by this deprecation ? Devs not 
>> having enough to do already ?
>> The problem (for open source) with "force-replacing" the uses of 
>> `md5/sha1*` functions with the `hash` function calls, is that the 
>> hash extension was not part of PHP core until PHP 7.4, which means 
>> that for a significant number of open source projects, the 
>> replacement is not a one-on-one function call replacement, but needs 
>> guard code for PHP < 7.4 in case the hash extension is not available.
>
> From the docs it looks like the hash function was part of the core 
> since php 5.1.2 but perhaps I read that wrongly from the docs.
>
> Anyhow, a replacement could possibly be to declare a userland function 
> that then does the version check and either calls the respective 
> function directly or delegates to the hash-function.
>

Agreed, but the fact that it is solvable, is not a justification for 
adding "busy-work" when the replacement for the deprecated function is, 
by all accounts, just as bad/incorrect as the original....

I don't mind putting the work in when there is a good justification, but 
I don't see one for this deprecation.

Smile,
Juliette


--------------020008000405050606010805
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">On 8-7-2024 6:57, Andreas Heigl wrote:<br>
    </div>
    <blockquote
      cite="mid:4cf169f4-e222-4140-aef7-20eb5b871d32@heigl.org"
      type="cite">
      <br>
      <br>
      Am 08.07.24 um 05:04 schrieb Juliette Reinders Folmer:
      <br>
      [...]
      <br>
      <blockquote type="cite">
        <br>
        I also don't agree that there are "more appropriate replacements
        available".
        <br>
        The  suggested `hash()` replacements for the md5/sha1* functions
        have the exact same functionality, which the RFC considers
        "incorrect use", so what are we actually solving by this
        deprecation ? Devs not having enough to do already ?
        <br>
        The problem (for open source) with "force-replacing" the uses of
        `md5/sha1*` functions with the `hash` function calls, is that
        the hash extension was not part of PHP core until PHP 7.4, which
        means that for a significant number of open source projects, the
        replacement is not a one-on-one function call replacement, but
        needs guard code for PHP &lt; 7.4 in case the hash extension is
        not available.
        <br>
      </blockquote>
      <br>
      From the docs it looks like the hash function was part of the core
      since php 5.1.2 but perhaps I read that wrongly from the docs.
      <br>
      <br>
      Anyhow, a replacement could possibly be to declare a userland
      function that then does the version check and either calls the
      respective function directly or delegates to the hash-function.
      <br>
      <br>
    </blockquote>
    <br>
    Agreed, but the fact that it is solvable, is not a justification for
    adding "busy-work" when the replacement for the deprecated function
    is, by all accounts, just as bad/incorrect as the original....<br>
    <br>
    I don't mind putting the work in when there is a good justification,
    but I don't see one for this deprecation.<br>
    <br>
    Smile,<br>
    Juliette<br>
    <br>
  </body>
</html>

--------------020008000405050606010805--