Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124253
Precedence: bulk
MIME-Version: 1.0
References: <50DEC8FF-FBE1-4B39-AACD-076683499897@koalephant.com>
In-Reply-To: <50DEC8FF-FBE1-4B39-AACD-076683499897@koalephant.com>
Date: Sun, 7 Jul 2024 12:26:00 +0300
Message-ID: <CAH5C8xX_g1ix8K7c8sXn_Kj7uXFPyb18pWipNXV8tQ51fJYRcQ@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add WHATWG compliant URL parsing API
To: Stephen Reay <php-lists@koalephant.com>
Cc: Bilge <bilge@scriptfusion.com>, internals@lists.php.net
Content-Type: multipart/alternative; boundary="0000000000003cf7b8061ca4e3f1"
From: kocsismate90@gmail.com (=?UTF-8?B?TcOhdMOpIEtvY3Npcw==?=)

--0000000000003cf7b8061ca4e3f1
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Stephen,

I agree with the others, the static parser class is weird. Either put the
> static methods on the url class, or make the parser an instance with
> options.
>

Yes, I was sure that many people would find the signature of the parser
weird, and I can totally understand it. Since I
don't have hard feelings about any of the approaches, I'll try to find out
what way the proposal should be changed.
For the record, let me repeat my explanation about the current design
choice that I expressed in my reply to Niels:

... one of my major design goals was to make the UrlParser class to be
> extendable and configurable (e.g. via an "engine" property similar to wha=
t
> Random/Randomizer has). Of course, UrlParser
> doesn't support any of this yet, but at least the possibility is there fo=
r
> followup RFCs due to the class being final.
>


Since I knew it would be an overkill to require instantiating an UrlParser
> instance for a task which is stateless (URL parsing),
> finally I settled on using static methods for the purpose. Later, if the
> need arises, the static methods could be converted to
> non-static ones with minimal BC impact.


 Regards,
M=C3=A1t=C3=A9

--0000000000003cf7b8061ca4e3f1
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi Stephen,</div><div dir=3D"ltr"><br></d=
iv><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:=
1ex">
I agree with the others, the static parser class is weird. Either put the s=
tatic methods on the url class, or make the parser an instance with options=
.<br></blockquote><div><br></div><div>Yes, I was sure that many people woul=
d find the signature of the parser weird, and I can totally understand it. =
Since I</div><div>don&#39;t have hard feelings about any of the approaches,=
 I&#39;ll try to find out what way the proposal should be changed.</div><di=
v>For the record, let me repeat my explanation about the=C2=A0current desig=
n choice that I expressed in=C2=A0my reply to Niels:</div><div><br></div><d=
iv><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bord=
er-left:1px solid rgb(204,204,204);padding-left:1ex">... one of my major de=
sign goals was to make the UrlParser class to be<br>extendable and configur=
able (e.g. via an &quot;engine&quot; property similar to what Random/Random=
izer has). Of course, UrlParser<br>doesn&#39;t support any of this yet, but=
 at least the possibility is there for followup RFCs due to the class being=
 final.<br></blockquote><blockquote class=3D"gmail_quote" style=3D"margin:0=
px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">=
=C2=A0</blockquote><blockquote class=3D"gmail_quote" style=3D"margin:0px 0p=
x 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Since =
I knew it would be an overkill to require instantiating an UrlParser instan=
ce for a task which is stateless (URL parsing),<br>finally I settled on usi=
ng static methods for the purpose. Later, if the need=C2=A0arises, the stat=
ic methods could be converted to<br>non-static ones with minimal BC impact.=
</blockquote><div><br></div><div>=C2=A0Regards,</div></div><div>M=C3=A1t=C3=
=A9</div><div><br></div></div></div>

--0000000000003cf7b8061ca4e3f1--