Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124247
Message-ID: <2315222d-ab2e-4639-89be-e48420521a46@gmail.com>
Date: Sat, 6 Jul 2024 15:02:55 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] [RFC]I'd like to see the RFCs that deprecate the FFI
 non-static approach start voting
To: internals@lists.php.net
References: <BF8962F9-1A2B-43E1-8B59-68DBDA2DBA7D@sakiot.com>
 <462AD8D8-C32B-4C62-8A5D-99396CDE31FA@sakiot.com>
Content-Language: en-US
In-Reply-To: <462AD8D8-C32B-4C62-8A5D-99396CDE31FA@sakiot.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: dossche.niels@gmail.com (Niels Dossche)

On 06/07/2024 11:55, Saki Takamachi wrote:
> ﻿Hi,
> 
>>> ﻿The reason I'm not so polite is because I'm so angry. Firstly, the Deprecate functions with overloaded signatures RFC's  approach to FFI recommendations is unfounded, and secondly, the PR commit(https://github.com/php/php-src/commit/4acf0084dcd63ec369a610ec966db33f322694c8) has not been voted on by the RFC, and the implementation is very simple and crude, and does not solve the problem that FFI's API is not so elegant （At the very least, there are shortcomings such as complicated API calls, mixed use of multiple types of functions, and reduced performance）.
>>> There are so many masters,I don't understand why it was merged. The commit implementation was not voted on, and it is possible to withdraw it first.
>>
>> If I'm not misunderstanding something, they were voted on.
>>
>> https://wiki.php.net/rfc/deprecate_functions_with_overloaded_signatures
>>
>> Regards,
>>
>> Saki
> 
> I may have misunderstood what you were saying.
> 
> I'm starting to get a little confused.
> What exactly do you mean by voting on a commit?
> 
> Regards,
> 
> Saki

They think the PR is not part of the RFC and is landing in 8.4.
The PR is in fact already part of 8.3 and was voted on by the RFC that Saki pointed out.

Regards
Niels