Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124238
Message-ID: <E4DAA6AC-18D2-43E8-9D3E-63F1EDED7483@newclarity.net>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_3B1CEFB1-C627-40F3-B037-5D2F033355E3"
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.8\))
Subject: Re: [PHP-DEV] [RFC] Deprecations for PHP 8.4
Date: Fri, 5 Jul 2024 21:22:20 -0400
In-Reply-To: <76838718-E108-4A08-A88F-4965FB81E52C@gmail.com>
Cc: "Gina P. Banyard" <internals@gpb.moe>,
 PHP internals <internals@lists.php.net>
To: Claude Pache <claude.pache@gmail.com>
References: <bw20I5b7ly3lSbI-2Bv3kfrfTVJbDo5RhwBiQa1PEwuLjprDJWptPajLiaialj1RLVKu7z1j0MofJUhhRVtzT_5i2E11oKeQx_VMUxnKhUE=@gpb.moe>
 <76838718-E108-4A08-A88F-4965FB81E52C@gmail.com>
From: mike@newclarity.net (Mike Schinkel)


--Apple-Mail=_3B1CEFB1-C627-40F3-B037-5D2F033355E3
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


> On Jul 5, 2024, at 1:11 PM, Claude Pache <claude.pache@gmail.com> =
wrote:
>> Le 25 juin 2024 =C3=A0 16:36, Gina P. Banyard <internals@gpb.moe> a =
=C3=A9crit :
>> https://wiki.php.net/rfc/deprecations_php_8_4
>=20
>=20
> * About strtok(): An exact replacement of `strtok()` that is =
reasonably performant may be constructed with a sequence of strspn(...) =
and strcspn(...) calls; here is an implementation using a generator in =
order to keep the state: https://3v4l.org/926tC <https://3v4l.org/926tC>
Well your modern_strtok() function is not an _exact_ replacement as it =
requires using a generator and thus forces the restructure of the code =
that calls strtok().=20

So not a drop-in =E2=80=94 search-and-replace =E2=80=94 replacement for =
strtok(). But it is a reasonable replacement for those who are motivated =
to do the restructure.

=3D=3D=3D=3D=3D=3D=3D=3D

Just out a curiosity for the performance of your modern_strtok() =
function so I benchmarked it and found it takes =E2=80=94 on rough =
average =E2=80=94 about ~2.5 times as long to run compared to when using =
strtok():

https://3v4l.org/AMECf#v8.3.9 <https://3v4l.org/AMECf#v8.3.9>

That makes yours the fastest alternative I have benchmarked, but =
significantly still slower than strtok().

I was curious to see if I could improve its performance by avoiding the =
generator, but that just made it slightly worse, e.g. taking =E2=80=94 =
on rough average =E2=80=94 ~2.75 times as long to run as `strtok()`:

https://3v4l.org/ZVS5Md#v8.3.9 <https://3v4l.org/ZVS5Md#v8.3.9>

#fwiw

-Mike=

--Apple-Mail=_3B1CEFB1-C627-40F3-B037-5D2F033355E3
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=utf-8

<html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; =
charset=3Dutf-8"></head><body style=3D"word-wrap: break-word; =
-webkit-nbsp-mode: space; line-break: after-white-space;" class=3D""><br =
class=3D""><div><blockquote type=3D"cite" class=3D""><div class=3D"">On =
Jul 5, 2024, at 1:11 PM, Claude Pache &lt;<a =
href=3D"mailto:claude.pache@gmail.com" =
class=3D"">claude.pache@gmail.com</a>&gt; wrote:</div><div class=3D""><div=
 style=3D"overflow-wrap: break-word; -webkit-nbsp-mode: space; =
line-break: after-white-space;" class=3D""><div class=3D""><blockquote =
type=3D"cite" class=3D""><div class=3D"">Le 25 juin 2024 =C3=A0 16:36, =
Gina P. Banyard &lt;<a href=3D"mailto:internals@gpb.moe" =
class=3D"">internals@gpb.moe</a>&gt; a =C3=A9crit :</div><div =
class=3D""><div class=3D""><a =
href=3D"https://wiki.php.net/rfc/deprecations_php_8_4" =
class=3D"">https://wiki.php.net/rfc/deprecations_php_8_4</a><br =
class=3D""></div></div></blockquote></div><div class=3D""><br =
class=3D""></div><div class=3D"">* About strtok(): An exact replacement =
of `strtok()` that is reasonably performant may be constructed with a =
sequence of strspn(...) and strcspn(...) calls; here is an =
implementation using a generator in order to keep the state:&nbsp;<a =
href=3D"https://3v4l.org/926tC" =
class=3D"">https://3v4l.org/926tC</a></div></div></div></blockquote><div><=
br class=3D""></div><div>Well your&nbsp;modern_strtok() function is not =
an _exact_ replacement as it requires using a generator and thus forces =
the restructure of the code that calls strtok().&nbsp;</div><div><br =
class=3D""></div><div>So not a drop-in =E2=80=94 search-and-replace =E2=80=
=94 replacement for strtok(). But it is a reasonable replacement for =
those who are motivated to do the restructure.</div><div><br =
class=3D""></div><div>=3D=3D=3D=3D=3D=3D=3D=3D</div><div><br =
class=3D""></div><div>Just out a curiosity for the performance of your =
modern_strtok() function so I benchmarked it and found it takes =E2=80=94 =
on rough average =E2=80=94 about ~2.5 times as long to run compared to =
when using strtok():</div><div><br class=3D""></div><div><font =
color=3D"#0068da" class=3D""><u class=3D""><a =
href=3D"https://3v4l.org/AMECf#v8.3.9" =
class=3D"">https://3v4l.org/AMECf#v8.3.9</a></u></font></div><div><br =
class=3D""></div><div>That makes yours the fastest alternative I =
have&nbsp;benchmarked, but significantly still slower than =
strtok().</div><div><br class=3D""></div></div><div class=3D"">I was =
curious to see if I could improve its performance by avoiding the =
generator, but that just made it slightly worse, e.g. taking =E2=80=94 =
on rough average =E2=80=94 ~2.75 times as long to run as =
`strtok()`:</div><div class=3D""><br class=3D""></div><div class=3D""><a =
href=3D"https://3v4l.org/ZVS5Md#v8.3.9" =
class=3D"">https://3v4l.org/ZVS5Md#v8.3.9</a></div><div class=3D""><br =
class=3D""></div><div class=3D"">#fwiw</div><div class=3D""><br =
class=3D""></div><div class=3D"">-Mike</div></body></html>=

--Apple-Mail=_3B1CEFB1-C627-40F3-B037-5D2F033355E3--