Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124228
Message-ID: <99fbd494-0ceb-4d2c-a733-6a42d1b3b3ae@bastelstu.be>
Date: Fri, 5 Jul 2024 14:28:39 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] [VOTE] Correctly name the rounding mode and make it an
 Enum
To: PHP internals <internals@lists.php.net>, Saki Takamachi <saki@sakiot.com>
References: <15beb37b-df78-46c2-a84b-878f3ff27bd8@bastelstu.be>
Content-Language: en-US
In-Reply-To: <15beb37b-df78-46c2-a84b-878f3ff27bd8@bastelstu.be>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 7/3/24 08:32, Tim Düsterhus wrote:
> RFC Text:
> https://wiki.php.net/rfc/correctly_name_the_rounding_mode_and_make_it_an_enum
> Discussion Thread: https://externals.io/message/123472

I have just added a link to the implementation of the enum and the 
changes to `round()` to the RFC. Saki will handle the changes to ext/bcmath.

You can find my PR at: https://github.com/php/php-src/pull/14833

I have also fixed an error in the explanation of the 'PositiveInfinity' 
rounding mode [1]. It previously read:

 > Round to the largest integer that is greater or equal.

but it should read:

 > Round to the ***smallest*** integer that is greater or equal.

I apologize for the confusion this may have caused.

Best regards
Tim Düsterhus

[1] 
https://wiki.php.net/rfc/correctly_name_the_rounding_mode_and_make_it_an_enum?do=diff&rev2%5B0%5D=1720182318&rev2%5B1%5D=1720182387&difftype=sidebyside