Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124191
Feedback-ID: ifab94697:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-566-g3812ddbbc-fm-20240627.001-g3812ddbb
Precedence: bulk
MIME-Version: 1.0
Message-ID: <557008ce-30c4-4002-b731-1faabe487e64@app.fastmail.com>
In-Reply-To: <E0A16D3F-2B29-4037-AF3C-D51B929A8EF2@gmail.com>
References: <fbf45a9a-0385-4c42-a6a0-4f3ee1c8728d@app.fastmail.com>
 <8A3C2FDA-60DF-45A1-BA9D-11B6FB6F755C@gmail.com>
 <E0A16D3F-2B29-4037-AF3C-D51B929A8EF2@gmail.com>
Date: Wed, 03 Jul 2024 14:42:10 +0200
To: "Claude Pache" <claude.pache@gmail.com>,
 "Larry Garfield" <larry@garfieldtech.com>
Cc: "php internals" <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] Property Hook improvements
Content-Type: multipart/alternative;
 boundary=947a888f9ed74860acfe150519f397c7
From: rob@bottled.codes ("Rob Landers")

--947a888f9ed74860acfe150519f397c7
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 3, 2024, at 14:28, Claude Pache wrote:
>=20
>=20
>> Le 3 juil. 2024 =C3=A0 11:54, Claude Pache <claude.pache@gmail.com> a=
 =C3=A9crit :
>>=20
>>=20
>> 2. As for readonly, I think that the invariant it is supposed to prov=
ide should be enforced as strictly as possible. It means that `readonly`=
 is only acceptable if there is no `get` hook.
>=20
> Hi,
>=20
> One more thing, why I think that we should be strict here. It is not j=
ust for preventing the user to write *dumb* code, it is also for prevent=
ing them to write *creative* code, e.g.
>=20
> ```php
> class doc {
>     public readonly int page {
>         get =3D> $this->page + $this->offset;
>     }
>     private int $offset =3D 0;
>     public function __construct(int $page) {
>         $this->page =3D $page;
>     }
>     public function foo() {
>         // $this->offset may be adjusted here
>     }
> }
> ```
>=20
> =E2=80=94Claude

I don't see anything wrong with that code. $page doesn't say "immutable"=
 it says "readonly", as in "cannot write to".

=E2=80=94 Rob
--947a888f9ed74860acfe150519f397c7
Content-Type: text/html;charset=utf-8
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Wed, Jul 3, =
2024, at 14:28, Claude Pache wrote:<br></div><blockquote type=3D"cite" i=
d=3D"qt" style=3D"overflow-wrap:break-word;"><div><br></div><div><div><b=
r></div><blockquote type=3D"cite"><div>Le 3 juil. 2024 =C3=A0 11:54, Cla=
ude Pache &lt;claude.pache@gmail.com&gt; a =C3=A9crit :<br></div><div><b=
r></div><div><div style=3D"overflow-wrap:break-word;"><div><br></div><di=
v><div>2. As for readonly, I think that the invariant it is supposed to =
provide should be enforced as strictly as possible. It means that `reado=
nly` is only acceptable if there is no `get` hook<span class=3D"size" st=
yle=3D"font-size:13px;">.</span><br></div></div></div></div></blockquote=
><div><br></div><div>Hi,<br></div><div><br></div><div>One more thing, wh=
y I think that we should be strict here. It is not just for preventing t=
he user to write *dumb* code, it is also for preventing them to write *c=
reative* code, e.g.<br></div><div><br></div><div>```php<br></div><div><d=
iv>class doc {<br></div><div>&nbsp; &nbsp; public readonly int page {<br=
></div><div>&nbsp; &nbsp; &nbsp; &nbsp; get =3D&gt; $this-&gt;page + $th=
is-&gt;offset;<br></div><div>&nbsp; &nbsp; }<br></div><div>&nbsp; &nbsp;=
 private int $offset =3D 0;<br></div><div>&nbsp; &nbsp; public function =
__construct(int $page) {<br></div><div>&nbsp; &nbsp; &nbsp; &nbsp; $this=
-&gt;page =3D $page;<br></div><div>&nbsp; &nbsp; }<br></div><div>&nbsp; =
&nbsp; public function foo() {<br></div><div>&nbsp; &nbsp; &nbsp; &nbsp;=
 // $this-&gt;offset may be adjusted here<br></div><div>&nbsp; &nbsp; }<=
br></div><div>}<br></div><div>```<br></div><div><br></div><div>=E2=80=94=
Claude<br></div></div></div></blockquote><div><br></div><div>I don't see=
 anything wrong with that code. $page doesn't say "immutable" it says "r=
eadonly", as in "cannot write to".</div><div><br></div><div id=3D"sig121=
229152">=E2=80=94 Rob<br></div></body></html>
--947a888f9ed74860acfe150519f397c7--