Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124190
Message-ID: <E0A16D3F-2B29-4037-AF3C-D51B929A8EF2@gmail.com>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_58B1A5E5-A5FB-44A1-B462-751BFDF08D09"
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\))
Subject: Re: [PHP-DEV] [RFC] Property Hook improvements
Date: Wed, 3 Jul 2024 14:28:04 +0200
In-Reply-To: <8A3C2FDA-60DF-45A1-BA9D-11B6FB6F755C@gmail.com>
Cc: php internals <internals@lists.php.net>
To: Larry Garfield <larry@garfieldtech.com>
References: <fbf45a9a-0385-4c42-a6a0-4f3ee1c8728d@app.fastmail.com>
 <8A3C2FDA-60DF-45A1-BA9D-11B6FB6F755C@gmail.com>
From: claude.pache@gmail.com (Claude Pache)


--Apple-Mail=_58B1A5E5-A5FB-44A1-B462-751BFDF08D09
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> Le 3 juil. 2024 =C3=A0 11:54, Claude Pache <claude.pache@gmail.com> a =
=C3=A9crit :
>=20
>=20
> 2. As for readonly, I think that the invariant it is supposed to =
provide should be enforced as strictly as possible. It means that =
`readonly` is only acceptable if there is no `get` hook.

Hi,

One more thing, why I think that we should be strict here. It is not =
just for preventing the user to write *dumb* code, it is also for =
preventing them to write *creative* code, e.g.

```php
class doc {
    public readonly int page {
        get =3D> $this->page + $this->offset;
    }
    private int $offset =3D 0;
    public function __construct(int $page) {
        $this->page =3D $page;
    }
    public function foo() {
        // $this->offset may be adjusted here
    }
}
```

=E2=80=94Claude


--Apple-Mail=_58B1A5E5-A5FB-44A1-B462-751BFDF08D09
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=utf-8

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; =
charset=3Dutf-8"></head><body style=3D"overflow-wrap: break-word; =
-webkit-nbsp-mode: space; line-break: after-white-space;"><br =
id=3D"lineBreakAtBeginningOfMessage"><div><br><blockquote =
type=3D"cite"><div>Le 3 juil. 2024 =C3=A0 11:54, Claude Pache =
&lt;claude.pache@gmail.com&gt; a =C3=A9crit :</div><br =
class=3D"Apple-interchange-newline"><div><meta http-equiv=3D"content-type"=
 content=3D"text/html; charset=3Dutf-8"><div style=3D"overflow-wrap: =
break-word; -webkit-nbsp-mode: space; line-break: =
after-white-space;"><br><div><div>2. As for readonly, I think that the =
invariant it is supposed to provide should be enforced as strictly as =
possible. It means that `readonly` is only acceptable if there is no =
`get` hook<span style=3D"font-size: =
13px;">.</span></div></div></div></div></blockquote><div><br></div>Hi,<br>=
<div><br></div><div>One more thing, why I think that we should be strict =
here. It is not just for preventing the user to write *dumb* code, it is =
also for preventing them to write *creative* code, =
e.g.</div><div><br></div><div>```php</div><div><div>class doc =
{</div><div>&nbsp; &nbsp; public readonly int page {</div><div>&nbsp; =
&nbsp; &nbsp; &nbsp; get =3D&gt; $this-&gt;page + =
$this-&gt;offset;</div><div>&nbsp; &nbsp; }</div><div>&nbsp; &nbsp; =
private int $offset =3D 0;</div><div>&nbsp; &nbsp; public function =
__construct(int $page) {</div><div>&nbsp; &nbsp; &nbsp; &nbsp; =
$this-&gt;page =3D $page;</div><div>&nbsp; &nbsp; }</div><div>&nbsp; =
&nbsp; public function foo() {</div><div>&nbsp; &nbsp; &nbsp; &nbsp; // =
$this-&gt;offset may be adjusted here</div><div>&nbsp; &nbsp; =
}</div><div>}</div><div>```</div><div><br></div><div>=E2=80=94Claude</div>=
</div></div><br></body></html>=

--Apple-Mail=_58B1A5E5-A5FB-44A1-B462-751BFDF08D09--