Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124180
Precedence: bulk
MIME-Version: 1.0
References: <F2B3A732-A680-4729-B642-75B3694EA9D7@sakiot.com> <101A7B8C-6BC3-4E9D-A5CB-059380E34332@sakiot.com>
In-Reply-To: <101A7B8C-6BC3-4E9D-A5CB-059380E34332@sakiot.com>
Date: Tue, 2 Jul 2024 10:05:02 -0700
Message-ID: <CAMrTa2EPqwGSBwPcpq6PreCjhP1zZ81PxykQtfG1DkUvX18QLw@mail.gmail.com>
Subject: Re: [PHP-DEV] Re: [RFC] [Discussion] Fix up BCMath Number Class /
 Change GMP bool cast behavior
To: Saki Takamachi <saki@sakiot.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000096d335061c46b7b6"
From: jordan.ledoux@gmail.com (Jordan LeDoux)

--00000000000096d335061c46b7b6
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 2, 2024 at 4:06=E2=80=AFAM Saki Takamachi <saki@sakiot.com> wro=
te:

> Hi all,
>
> > Hi internals,
> >
> > Created a follow-up RFC for the BCMath\Number class. This RFC also
> contains proposed changes to GMP's bool cast. I have proposed similar
> changes to BCMath, so for procedural efficiency I have combined them into
> the same RFC.
> >
> > Note that although they are combined into one RFC, these votes are take=
n
> independently.
> >
> > https://wiki.php.net/rfc/fix_up_bcmath_number_class
> >
> > Regards,
> >
> > Saki
>
>
> Added changes to RFC. It is a proposal to remove all rounding during
> calculations due to convenience issues and the fact that the functionalit=
y
> is "excessive" to begin with.
>
> To be precise, it will have the same truncation behavior as the existing
> BCMath function, making it impossible for users to change this behavior
> during calculations. If the user wants to perform rounding, they must
> always use the `round()` method.
>
> Regards,
>
> Saki


This seems positive to me. Rounding being explicit makes more sense.

Jordan

--00000000000096d335061c46b7b6
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Tue, Jul 2, 2024 at 4:06=E2=80=AFA=
M Saki Takamachi &lt;<a href=3D"mailto:saki@sakiot.com">saki@sakiot.com</a>=
&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px =
0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi a=
ll,<br>
<br>
&gt; Hi internals,<br>
&gt; <br>
&gt; Created a follow-up RFC for the BCMath\Number class. This RFC also con=
tains proposed changes to GMP&#39;s bool cast. I have proposed similar chan=
ges to BCMath, so for procedural efficiency I have combined them into the s=
ame RFC.<br>
&gt; <br>
&gt; Note that although they are combined into one RFC, these votes are tak=
en independently.<br>
&gt; <br>
&gt; <a href=3D"https://wiki.php.net/rfc/fix_up_bcmath_number_class" rel=3D=
"noreferrer" target=3D"_blank">https://wiki.php.net/rfc/fix_up_bcmath_numbe=
r_class</a><br>
&gt; <br>
&gt; Regards,<br>
&gt; <br>
&gt; Saki<br>
<br>
<br>
Added changes to RFC. It is a proposal to remove all rounding during calcul=
ations due to convenience issues and the fact that the functionality is &qu=
ot;excessive&quot; to begin with.<br>
<br>
To be precise, it will have the same truncation behavior as the existing BC=
Math function, making it impossible for users to change this behavior durin=
g calculations. If the user wants to perform rounding, they must always use=
 the `round()` method.<br>
<br>
Regards,<br>
<br>
Saki</blockquote><div><br></div><div>This seems positive to me. Rounding be=
ing explicit makes more sense.</div><div><br></div><div>Jordan <br></div></=
div></div>

--00000000000096d335061c46b7b6--