Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124172
Feedback-ID: ifab94697:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-566-g3812ddbbc-fm-20240627.001-g3812ddbb
Precedence: bulk
MIME-Version: 1.0
Message-ID: <ec5e895d-4113-4d6b-8aa6-4fa409b6d390@app.fastmail.com>
In-Reply-To: 
 <CABTDVhAXLuiKtbz4P_jwhHe=h_r62037mRE2Eg-864DoweOahw@mail.gmail.com>
References: 
 <CABTDVhAXLuiKtbz4P_jwhHe=h_r62037mRE2Eg-864DoweOahw@mail.gmail.com>
Date: Tue, 02 Jul 2024 08:22:19 +0200
To: internals@lists.php.net
Subject: Re: [PHP-DEV] [Discussion] Add date_test_set_now() function
Content-Type: multipart/alternative;
 boundary=872cf03f20164e1eb8e4cd042a7e56c9
From: rob@bottled.codes ("Rob Landers")

--872cf03f20164e1eb8e4cd042a7e56c9
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable



On Mon, Jul 1, 2024, at 15:07, Go Kudo wrote:
> Hi, Internals.
>=20
> I've been absent for a long time due to poor health. I'm finally back.
>=20
> I maintain a legacy application written in PHP, and occasionally need =
to fake the current time for testing purposes. However, PHP doesn't prov=
ide a standard way to fake the current time, so I've been changing the O=
S's current time to do this, which is quite painful.
>=20
> This can be avoided by using third-party libraries (such as Carbon::se=
tTestNow()). However, it's almost impossible to modify all parts of a le=
gacy application that depend on the current time.
>=20
> Another option is to use libfaketime (https://github.com/wolfcw/libfak=
etime), but this is also quite painful to use.
>=20
> Since this was absolutely necessary for my work, I implemented this fu=
nctionality as a PHP Extension. (Please ignore the dirty implementation =
related to PDO. I'm not planning to propose it this time.)
>=20
> https://github.com/colopl/php-colopl_timeshifter
>=20
> However, this Extension has some problems.
>=20
> The first is that there's no way to determine whether the format passe=
d to the ext-date parser is relative or absolute time, resulting in a di=
rty hack using usleep. The second is that it depends on timelib, so it b=
reaks when upstream changes related to timelib are made.
>=20
> So, how about adding a `date_set_test_now(\DateInterval $shiftInterval=
)` function to ext-date?
>=20
> This function would treat the current time as shifted by the passed Da=
teInterval. Since it's implemented on the ext-date side, there's no need=
 for dirty hacks using usleep.
>=20
> I'd like to hear your opinions. Thank you.
>=20
> Best Regards,
> Go Kudo
Welcome back!

I think this is an interesting proposal and very useful. I think many pe=
ople may be concerned about it being used in a non-testing context, but =
I don=E2=80=99t think we should stop people from being creative. If peop=
le find a use for it outside of testing, that would be interesting to se=
e. The fact they can already do this today via carbon just makes a point=
 that this is valuable to those of us who don=E2=80=99t like adding depe=
ndencies.

Ps. Anytime someone mentions PSR, have your favorite drink. It=E2=80=99l=
l help take the edge off. :) In all seriousness, PSR doesn=E2=80=99t app=
ly universally and shouldn=E2=80=99t ever be a valid argument on this li=
st. That=E2=80=99s my 2=C2=A2 anyway, best of luck to you.=20

=E2=80=94 Rob
--872cf03f20164e1eb8e4cd042a7e56c9
Content-Type: text/html;charset=utf-8
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div><br></div><div>=
<br></div><div>On Mon, Jul 1, 2024, at 15:07, Go Kudo wrote:<br></div><b=
lockquote type=3D"cite" id=3D"qt" style=3D""><div dir=3D"ltr"><div>Hi, I=
nternals.<br></div><div><br></div><div><div>I've been absent for a long =
time due to poor health. I'm finally back.<br></div><div><br></div><div>=
I maintain a legacy application written in PHP, and occasionally need to=
 fake the current time for testing purposes. However, PHP doesn't provid=
e a standard way to fake the current time, so I've been changing the OS'=
s current time to do this, which is quite painful.<br></div><div><br></d=
iv><div>This can be avoided by using third-party libraries (such as Carb=
on::setTestNow()). However, it's almost impossible to modify all parts o=
f a legacy application that depend on the current time.<br></div><div><b=
r></div><div>Another option is to use libfaketime (<a href=3D"https://gi=
thub.com/wolfcw/libfaketime">https://github.com/wolfcw/libfaketime</a>),=
 but this is also quite painful to use.<br></div><div><br></div><div>Sin=
ce this was absolutely necessary for my work, I implemented this functio=
nality as a PHP Extension. (Please ignore the dirty implementation relat=
ed to PDO. I'm not planning to propose it this time.)<br></div><div><br>=
</div><div><a href=3D"https://github.com/colopl/php-colopl_timeshifter">=
https://github.com/colopl/php-colopl_timeshifter</a><br></div><div><br><=
/div><div>However, this Extension has some problems.<br></div><div><br><=
/div><div>The first is that there's no way to determine whether the form=
at passed to the ext-date parser is relative or absolute time, resulting=
 in a dirty hack using usleep. The second is that it depends on timelib,=
 so it breaks when upstream changes related to timelib are made.<br></di=
v><div><br></div><div>So, how about adding a `date_set_test_now(\DateInt=
erval $shiftInterval)` function to ext-date?<br></div><div><br></div><di=
v>This function would treat the current time as shifted by the passed Da=
teInterval. Since it's implemented on the ext-date side, there's no need=
 for dirty hacks using usleep.<br></div><div><br></div><div>I'd like to =
hear your opinions. Thank you.<br></div></div><div><br></div><div>Best R=
egards,<br></div><div>Go Kudo<br></div></div></blockquote><div>Welcome b=
ack!<br></div><div><br></div><div>I think this is an interesting proposa=
l and very useful. I think many people may be concerned about it being u=
sed in a non-testing context, but I don=E2=80=99t think we should stop p=
eople from being creative. If people find a use for it outside of testin=
g, that would be interesting to see. The fact they can already do this t=
oday via carbon just makes a point that this is valuable to those of us =
who don=E2=80=99t like adding dependencies.<br></div><div><br></div><div=
>Ps. Anytime someone mentions PSR, have your favorite drink. It=E2=80=99=
ll help take the edge off. :) In all seriousness, PSR doesn=E2=80=99t ap=
ply universally and shouldn=E2=80=99t ever be a valid argument on this l=
ist. That=E2=80=99s my 2=C2=A2 anyway, best of luck to you.&nbsp;<br></d=
iv><div><br></div><div id=3D"sig121229152">=E2=80=94 Rob<br></div></body=
></html>
--872cf03f20164e1eb8e4cd042a7e56c9--