Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124170
Precedence: bulk
MIME-Version: 1.0
References: <CABTDVhAXLuiKtbz4P_jwhHe=h_r62037mRE2Eg-864DoweOahw@mail.gmail.com>
In-Reply-To: <CABTDVhAXLuiKtbz4P_jwhHe=h_r62037mRE2Eg-864DoweOahw@mail.gmail.com>
Date: Tue, 2 Jul 2024 07:39:14 +0300
Message-ID: <CAAwdEzDVTUQ5qgz8T_20j3_DhVin2ZbtkLXEb94nfYae4-zN8A@mail.gmail.com>
Subject: Re: [PHP-DEV] [Discussion] Add date_test_set_now() function
To: Go Kudo <zeriyoshi@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000007b5757061c3c4c45"
From: drealecs@gmail.com (=?UTF-8?Q?Alexandru_P=C4=83tr=C4=83nescu?=)

--0000000000007b5757061c3c4c45
Content-Type: text/plain; charset="UTF-8"

>
>
> https://github.com/colopl/php-colopl_timeshifter
>
> However, this Extension has some problems.
>
> The first is that there's no way to determine whether the format passed to
> the ext-date parser is relative or absolute time, resulting in a dirty hack
> using usleep. The second is that it depends on timelib, so it breaks when
> upstream changes related to timelib are made.
>
> So, how about adding a `date_set_test_now(\DateInterval $shiftInterval)`
> function to ext-date?
>
> This function would treat the current time as shifted by the passed
> DateInterval. Since it's implemented on the ext-date side, there's no need
> for dirty hacks using usleep.
>
>

I can see how this would be useful on legacy applications, not forcing many
changes everywhere.

However, I think that we should not encourage this and keep it out of php
core offering.

Having it as a separate php extension sounds good to me, and as long as
that php extension is loaded and used only while running tests, it helps
with not possibly impacting production in any way.
Indeed, it mighty have some limitations but I think we can work around them.

An alternative solution would be to have namespaced functions and classes
and use rector to automate the replacement of native ones just before
running tests and package everything as a testing php library.

Alex

--0000000000007b5757061c3c4c45
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div class=3D"gmail_quote" dir=3D"auto"><blockquote class=
=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex"><div dir=3D"ltr"><br><a href=3D"https://github.com/colopl/php=
-colopl_timeshifter" rel=3D"noreferrer noreferrer" target=3D"_blank">https:=
//github.com/colopl/php-colopl_timeshifter</a><br><br>However, this Extensi=
on has some problems.<br><br>The first is that there&#39;s no way to determ=
ine whether the format passed to the ext-date parser is relative or absolut=
e time, resulting in a dirty hack using usleep. The second is that it depen=
ds on timelib, so it breaks when upstream changes related to timelib are ma=
de.<br><br>So, how about adding a `date_set_test_now(\DateInterval $shiftIn=
terval)` function to ext-date?<br><br>This function would treat the current=
 time as shifted by the passed DateInterval. Since it&#39;s implemented on =
the ext-date side, there&#39;s no need for dirty hacks using usleep.<br><br=
></div></blockquote></div><div dir=3D"auto"><br></div><div dir=3D"auto"><br=
></div><div dir=3D"auto">I can see how this would be useful on legacy appli=
cations, not forcing many changes everywhere.</div><div dir=3D"auto"><br></=
div><div dir=3D"auto">However, I think that we should not encourage this an=
d keep it out of php core offering.</div><div dir=3D"auto"><br></div><div d=
ir=3D"auto">Having it as a separate php extension sounds good to me, and as=
 long as that php extension is loaded and used only while running tests, it=
 helps with not possibly impacting production in any way.</div><div dir=3D"=
auto">Indeed, it mighty have some limitations but I think we can work aroun=
d them.</div><div dir=3D"auto"><br></div><div dir=3D"auto">An alternative s=
olution would be to have namespaced functions and classes and use rector to=
 automate the replacement of native ones just before running tests and pack=
age everything as a testing php library.</div><div dir=3D"auto">=C2=A0</div=
><div dir=3D"auto">Alex</div><div dir=3D"auto"><br></div></div>

--0000000000007b5757061c3c4c45--