Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124164
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-566-g3812ddbbc-fm-20240627.001-g3812ddbb
Precedence: bulk
MIME-Version: 1.0
Message-ID: <5616fb57-6687-4be1-9163-f6db849472de@app.fastmail.com>
In-Reply-To: <146aeda7-9025-499f-8062-9d3e8a52d383@bastelstu.be>
References: <fbf45a9a-0385-4c42-a6a0-4f3ee1c8728d@app.fastmail.com>
 <146aeda7-9025-499f-8062-9d3e8a52d383@bastelstu.be>
Date: Mon, 01 Jul 2024 20:57:53 +0000
To: "php internals" <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] Property Hook improvements
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: larry@garfieldtech.com ("Larry Garfield")

On Mon, Jul 1, 2024, at 8:32 PM, Tim D=C3=BCsterhus wrote:
> Hi
>
> On 7/1/24 19:02, Larry Garfield wrote:
>> I'd say we expect these to be uncontroversial, but this is PHP. :-)  =
So I will instead just note that it's a short RFC and open the discussio=
n accordingly.
>
> Big fan of the performance improvement, given that I convinced Ilija t=
o=20
> look into that once more. Really happy with what he found there.
>
> For the second part about supporting readonly: I don't want to rush th=
is=20
> in the last few weeks before feature freeze, especially since the word=20
> 'investigating' appears in the RFC text. Given that readonly is=20
> currently entirely unsupported, this could very well be added with PHP=20
> 8.5, allowing folks to really think about the implications and how it=20
> interacts with stuff. That's a "no" from my side.

"Investigating" here is a small term, honestly.  Ilija just hadn't had a=
 chance to poke at it to see where is more feasible.  I expect it would =
be a day or so at most to sort that part out; we just wanted to get the =
discussion going given the timing, and he didn't have time over the week=
end. :-)

Are there specific concerns you have about implications, or just a gener=
al "dude, it's July" sense?

> Best regards
> Tim D=C3=BCsterhus
>
> PS: Small typo: '$this-dbApi->loadCategory($this->categoryId);', '>'=20
> missing there after 'this-'.

Fixed, thanks.

--Larry Garfield