Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124162
Message-ID: <146aeda7-9025-499f-8062-9d3e8a52d383@bastelstu.be>
Date: Mon, 1 Jul 2024 22:32:29 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] [RFC] Property Hook improvements
To: Larry Garfield <larry@garfieldtech.com>,
 php internals <internals@lists.php.net>
References: <fbf45a9a-0385-4c42-a6a0-4f3ee1c8728d@app.fastmail.com>
Content-Language: en-US
In-Reply-To: <fbf45a9a-0385-4c42-a6a0-4f3ee1c8728d@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 7/1/24 19:02, Larry Garfield wrote:
> I'd say we expect these to be uncontroversial, but this is PHP. :-)  So I will instead just note that it's a short RFC and open the discussion accordingly.

Big fan of the performance improvement, given that I convinced Ilija to 
look into that once more. Really happy with what he found there.

For the second part about supporting readonly: I don't want to rush this 
in the last few weeks before feature freeze, especially since the word 
'investigating' appears in the RFC text. Given that readonly is 
currently entirely unsupported, this could very well be added with PHP 
8.5, allowing folks to really think about the implications and how it 
interacts with stuff. That's a "no" from my side.

Best regards
Tim Düsterhus

PS: Small typo: '$this-dbApi->loadCategory($this->categoryId);', '>' 
missing there after 'this-'.