Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124154
Precedence: bulk
MIME-Version: 1.0
References: <fbf45a9a-0385-4c42-a6a0-4f3ee1c8728d@app.fastmail.com>
In-Reply-To: <fbf45a9a-0385-4c42-a6a0-4f3ee1c8728d@app.fastmail.com>
Date: Mon, 1 Jul 2024 19:28:56 +0200
Message-ID: <CANS-=pe3S59w7AC=KGvtQA2i8dtc1rNR1LCZajLO6pKE8kKxTg@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Property Hook improvements
To: Larry Garfield <larry@garfieldtech.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000002c607f061c32f059"
From: kjarli@gmail.com (Lynn)

--0000000000002c607f061c32f059
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jul 1, 2024 at 7:05=E2=80=AFPM Larry Garfield <larry@garfieldtech.c=
om>
wrote:

> Hi folks.  As Ilija's been polishing off hooks to get the PR merged, we'v=
e
> run into two small revisions that should make life better for all
> involved.  One is a performance improvement that requires a very slight
> error handling behavior change, and the other is enabling readonly in
> selected (but probably all of the relevant) circumstances.
>
> I'd say we expect these to be uncontroversial, but this is PHP. :-)  So I
> will instead just note that it's a short RFC and open the discussion
> accordingly.
>
> https://wiki.php.net/rfc/hook_improvements
>
> --
>   Larry Garfield
>   larry@garfieldtech.com


"A side effect of that optimization, however, is that we cannot proactively
detect the bug above. Instead, it would result in an infinite loop, which
would eventually trigger a a stack overflow."

This got a small typo ("a a" at the end). This reads no different to me
than infinite recursion between 2 methods. It honestly does not bother me,
and any static analysis tool will be able to pick this anyway. Sounds like
a free performance gain to me!

--0000000000002c607f061c32f059
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Mon, Jul 1, 2024 at 7:05=E2=80=AFP=
M Larry Garfield &lt;<a href=3D"mailto:larry@garfieldtech.com">larry@garfie=
ldtech.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex">Hi folks.=C2=A0 As Ilija&#39;s been polishing off hooks to get t=
he PR merged, we&#39;ve run into two small revisions that should make life =
better for all involved.=C2=A0 One is a performance improvement that requir=
es a very slight error handling behavior change, and the other is enabling =
readonly in selected (but probably all of the relevant) circumstances.<br>
<br>
I&#39;d say we expect these to be uncontroversial, but this is PHP. :-)=C2=
=A0 So I will instead just note that it&#39;s a short RFC and open the disc=
ussion accordingly.<br>
<br>
<a href=3D"https://wiki.php.net/rfc/hook_improvements" rel=3D"noreferrer" t=
arget=3D"_blank">https://wiki.php.net/rfc/hook_improvements</a><br>
<br>
-- <br>
=C2=A0 Larry Garfield<br>
=C2=A0 <a href=3D"mailto:larry@garfieldtech.com" target=3D"_blank">larry@ga=
rfieldtech.com</a></blockquote><div><br></div><div>&quot;A side effect of t=
hat optimization, however, is that we cannot proactively detect the bug abo=
ve. Instead, it would result in an infinite loop, which would eventually tr=
igger a a stack overflow.&quot;<br><br>This got a small typo (&quot;a a&quo=
t; at the end). This reads no different to me than infinite recursion betwe=
en 2 methods. It honestly does not bother me, and any static analysis tool =
will be able to pick this anyway. Sounds like a free performance gain to me=
!</div><div><br></div><div><br></div></div></div>

--0000000000002c607f061c32f059--