Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124139
Precedence: bulk
MIME-Version: 1.0
Date: Mon, 1 Jul 2024 22:07:15 +0900
Message-ID: <CABTDVhAXLuiKtbz4P_jwhHe=h_r62037mRE2Eg-864DoweOahw@mail.gmail.com>
Subject: [PHP-DEV] [Discussion] Add date_test_set_now() function
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000062643a061c2f47da"
From: zeriyoshi@gmail.com (Go Kudo)

--00000000000062643a061c2f47da
Content-Type: text/plain; charset="UTF-8"

Hi, Internals.

I've been absent for a long time due to poor health. I'm finally back.

I maintain a legacy application written in PHP, and occasionally need to
fake the current time for testing purposes. However, PHP doesn't provide a
standard way to fake the current time, so I've been changing the OS's
current time to do this, which is quite painful.

This can be avoided by using third-party libraries (such as
Carbon::setTestNow()). However, it's almost impossible to modify all parts
of a legacy application that depend on the current time.

Another option is to use libfaketime (https://github.com/wolfcw/libfaketime),
but this is also quite painful to use.

Since this was absolutely necessary for my work, I implemented this
functionality as a PHP Extension. (Please ignore the dirty implementation
related to PDO. I'm not planning to propose it this time.)

https://github.com/colopl/php-colopl_timeshifter

However, this Extension has some problems.

The first is that there's no way to determine whether the format passed to
the ext-date parser is relative or absolute time, resulting in a dirty hack
using usleep. The second is that it depends on timelib, so it breaks when
upstream changes related to timelib are made.

So, how about adding a `date_set_test_now(\DateInterval $shiftInterval)`
function to ext-date?

This function would treat the current time as shifted by the passed
DateInterval. Since it's implemented on the ext-date side, there's no need
for dirty hacks using usleep.

I'd like to hear your opinions. Thank you.

Best Regards,
Go Kudo

--00000000000062643a061c2f47da
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi, Internals.<div><br></div><div>I&#39;ve been absent for=
 a long time due to poor health. I&#39;m finally back.<br><br>I maintain a =
legacy application written in PHP, and occasionally need to fake the curren=
t time for testing purposes. However, PHP doesn&#39;t provide a standard wa=
y to fake the current time, so I&#39;ve been changing the OS&#39;s current =
time to do this, which is quite painful.<br><br>This can be avoided by usin=
g third-party libraries (such as Carbon::setTestNow()). However, it&#39;s a=
lmost impossible to modify all parts of a legacy application that depend on=
 the current time.<br><br>Another option is to use libfaketime (<a href=3D"=
https://github.com/wolfcw/libfaketime">https://github.com/wolfcw/libfaketim=
e</a>), but this is also quite painful to use.<br><br>Since this was absolu=
tely necessary for my work, I implemented this functionality as a PHP Exten=
sion. (Please ignore the dirty implementation related to PDO. I&#39;m not p=
lanning to propose it this time.)<br><br><a href=3D"https://github.com/colo=
pl/php-colopl_timeshifter">https://github.com/colopl/php-colopl_timeshifter=
</a><br><br>However, this Extension has some problems.<br><br>The first is =
that there&#39;s no way to determine whether the format passed to the ext-d=
ate parser is relative or absolute time, resulting in a dirty hack using us=
leep. The second is that it depends on timelib, so it breaks when upstream =
changes related to timelib are made.<br><br>So, how about adding a `date_se=
t_test_now(\DateInterval $shiftInterval)` function to ext-date?<br><br>This=
 function would treat the current time as shifted by the passed DateInterva=
l. Since it&#39;s implemented on the ext-date side, there&#39;s no need for=
 dirty hacks using usleep.<br><br>I&#39;d like to hear your opinions. Thank=
 you.<br></div><div><br></div><div>Best Regards,</div><div>Go Kudo</div></d=
iv>

--00000000000062643a061c2f47da--