Newsgroups: php.internals,php.internals
Path: news.php.net
Xref: news.php.net php.internals:124106 php.internals:124107
Content-Type: text/plain;
	charset=utf-8
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\))
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add bcdivmod to BCMath
In-Reply-To: <e4a3fba1-e441-4f35-ac17-462f5f9c3fb9@app.fastmail.com>
Date: Mon, 1 Jul 2024 00:11:13 +0900
Cc: internals@lists.php.net
Content-Transfer-Encoding: quoted-printable
Message-ID: <3B23E039-D90F-4F84-9ECE-C6A9A3E145AF@sakiot.com>
References: <F709ADD3-502E-418B-82D3-34A681EBB7A0@sakiot.com>
 <668168A7.4040005@adviesenzo.nl>
 <e4a3fba1-e441-4f35-ac17-462f5f9c3fb9@app.fastmail.com>
To: Rob Landers <rob@bottled.codes>
From: saki@sakiot.com (Saki Takamachi)

Hi,

>> Just a suggestion: what about making the returned array an =
associative
>> array ? Like so:
>> ```
>> array(
>>      'quotient' =3D> 61,
>>      'remainder' =3D> 1,
>> );
>> ```
>> This would remove the need for devs to remember the order of the =
return
>> values and would make the return value self-documenting.
>=20
> An associative array would combine the worst of an array (no IDE =
autocompletion, no strong typing, increased memory usage) with the worst =
of an object (no easy way to extract the values into local variables =
with array destructuring).
>=20
> The example in the RFC doesn't show it, but the following makes the =
proposed API really convenient to use:
>=20
>    $slicesOfPizza =3D new BcMath\Number(8);
>    $mouthsToFeed =3D new BcMath\Number(3);
>    [$perMouth, $slicesLeft] =3D $slicesOfPizza->divmod($mouthsToFeed);
>=20
> Note how the order of values matches the words in the method name. =
First the result of 'div', then the result of 'mod=E2=80=99.


Thanks, I have added this example to the RFC (Please let me know if you =
have any problems).


> I came here to say the same thing. The best solution would be not =
having to refer to documentation or experiment with values, and this =
hits the nail on the head.
>=20
> The only thing that makes it weird is having to write it out, which at =
that point, it is probably faster to type out bcdiv and bcmod =
separately.
>=20
> Have you considered simply using references passed to the function? I =
feel like that is more idiomatically php.

Of course, that idea was proposed, but it was pointed out that current =
PHP tends to avoid such implementations, so we didn't adopt it. The =
reason why passing by reference was not adopted was added to the RFC.

Regards,

Saki=