Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124102
Precedence: bulk
MIME-Version: 1.0
References: <CANMwmbP4=cHj0Dye4b2uesefJs2gMPHKRYCSyvd3eaTJ+4cAyQ@mail.gmail.com>
 <KncosRapPMs_3wCzcaQPmMEGpLnYNkSZ9GDmBCEsisLKBR9DDbtxAGKZFD-xlMPxcgmj4CZ5RNxcklikaT9o1TztDtMc7aOD0NnTN5xLfmE=@gpb.moe>
 <CANMwmbOp12Bxi7zHz4kL3NBta7ccBqhkBGabk5TDJE-0CxZOuQ@mail.gmail.com>
 <66420855-9900-48a8-9964-b9dda81a8bdc@bastelstu.be> <CANMwmbMC-Q1dhqiG9rGcRqoNETTNQNy-U+hnXx6cmjH-7MFWWw@mail.gmail.com>
 <c64315af-ba2c-4148-8cb8-b3451d4574bd@bastelstu.be>
In-Reply-To: <c64315af-ba2c-4148-8cb8-b3451d4574bd@bastelstu.be>
Date: Sun, 30 Jun 2024 11:52:06 -0300
Message-ID: <CANMwmbN=3-1CXRimenQEiHaB8v60_esrdZnAAH=WiH6XCP6fpw@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC][Discussion] Enhance JSON error messages
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: "Gina P. Banyard" <internals@gpb.moe>, PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000007d8db5061c1ca0a9"
From: dev.juan.morales@gmail.com (juan carlos morales)

--0000000000007d8db5061c1ca0a9
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

El El dom, 30 de jun. de 2024 a la(s) 11:15, Tim D=C3=BCsterhus <tim@bastel=
stu.be>
escribi=C3=B3:

> Hi
>
> On 6/30/24 15:43, juan carlos morales wrote:
> > So, what I see here in my shortexperiencie is an RFC with 3 Options
>
> That is not an option. Each RFC needs a clear primary vote that is a
> "Yes/No" vote.
>
> > 1) Enhance the error message we already have
> >
> > 2) keep json_last_error_msg as it is and add a new function
> > json_last_error_info function
> >
> > 3) both
> >
>
> Adjusting error messages to make them better is not something that
> requires an RFC. We do this all the time without an RFC. Here's an
> example PR: https://github.com/php/php-src/pull/14496
>
> A new json_last_error_info() for easier programmatic access of the
> important bits can still be considered, but would not need an RFC either
> from my point of view. It's a simple and obvious addition. Those can be
> done without an RFC, unless someone complains.
>
> Best regards
> Tim D=C3=BCsterhus


>
Ok , then, i will prepare 2 PRs and lets see what happens then.

Thanks.

I will let everybody know When ready

--0000000000007d8db5061c1ca0a9
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div><br></div><div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=
=3D"gmail_attr">El El dom, 30 de jun. de 2024 a la(s) 11:15, Tim D=C3=BCste=
rhus &lt;<a href=3D"mailto:tim@bastelstu.be">tim@bastelstu.be</a>&gt; escri=
bi=C3=B3:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 =
.8ex;border-left:1px #ccc solid;padding-left:1ex">Hi<br>
<br>
On 6/30/24 15:43, juan carlos morales wrote:<br>
&gt; So, what I see here in my shortexperiencie is an RFC with 3 Options<br=
>
<br>
That is not an option. Each RFC needs a clear primary vote that is a <br>
&quot;Yes/No&quot; vote.<br>
<br>
&gt; 1) Enhance the error message we already have<br>
&gt; <br>
&gt; 2) keep json_last_error_msg as it is and add a new function<br>
&gt; json_last_error_info function<br>
&gt; <br>
&gt; 3) both<br>
&gt; <br>
<br>
Adjusting error messages to make them better is not something that <br>
requires an RFC. We do this all the time without an RFC. Here&#39;s an <br>
example PR: <a href=3D"https://github.com/php/php-src/pull/14496" rel=3D"no=
referrer" target=3D"_blank">https://github.com/php/php-src/pull/14496</a><b=
r>
<br>
A new json_last_error_info() for easier programmatic access of the <br>
important bits can still be considered, but would not need an RFC either <b=
r>
from my point of view. It&#39;s a simple and obvious addition. Those can be=
 <br>
done without an RFC, unless someone complains.<br>
<br>
Best regards<br>
Tim D=C3=BCsterhus</blockquote><blockquote class=3D"gmail_quote" style=3D"m=
argin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex" dir=3D"auto">=
<br>
</blockquote></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">Ok ,=
 then, i will prepare 2 PRs and lets see what happens then.</div><div dir=
=3D"auto"><br></div><div dir=3D"auto">Thanks.</div><div dir=3D"auto"><br></=
div><div dir=3D"auto">I will let everybody know When ready</div>

--0000000000007d8db5061c1ca0a9--