Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124101
Feedback-ID: ifab94697:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-538-g1508afaa2-fm-20240616.001-g1508afaa
Precedence: bulk
MIME-Version: 1.0
Message-ID: <e4a3fba1-e441-4f35-ac17-462f5f9c3fb9@app.fastmail.com>
In-Reply-To: <668168A7.4040005@adviesenzo.nl>
References: <F709ADD3-502E-418B-82D3-34A681EBB7A0@sakiot.com>
 <668168A7.4040005@adviesenzo.nl>
Date: Sun, 30 Jun 2024 16:51:42 +0200
To: internals@lists.php.net
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add bcdivmod to BCMath
Content-Type: multipart/alternative;
 boundary=c9403716f7c446d092c617a183892a7c
From: rob@bottled.codes ("Rob Landers")

--c9403716f7c446d092c617a183892a7c
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Sun, Jun 30, 2024, at 16:16, Juliette Reinders Folmer wrote:
> On 30-6-2024 16:04, Saki Takamachi wrote:
>> Hi internals,
>>=20
>> I created an RFC and put it in discussion status.
>> https://wiki.php.net/rfc/add_bcdivmod_to_bcmath
>>=20
>> I expect return values will probably be the main topic of discussion.
>>=20
>> Regards,
>>=20
>> Saki
>>=20
>=20
> Just a suggestion: what about making the returned array an associative=
 array ? Like so:
> ```
> array(
>     'quotient' =3D> 61,
>     'remainder' =3D> 1,
> );
> ```
>=20
> This would remove the need for devs to remember the order of the retur=
n values and would make the return value self-documenting.

I came here to say the same thing. The best solution would be not having=
 to refer to documentation or experiment with values, and this hits the =
nail on the head.

The only thing that makes it weird is having to write it out, which at t=
hat point, it is probably faster to type out bcdiv and bcmod separately.

Have you considered simply using references passed to the function? I fe=
el like that is more idiomatically php.

=E2=80=94 Rob
--c9403716f7c446d092c617a183892a7c
Content-Type: text/html;charset=utf-8
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Sun, Jun 30,=
 2024, at 16:16, Juliette Reinders Folmer wrote:<br></div><blockquote ty=
pe=3D"cite" id=3D"qt" style=3D""><div class=3D"qt-moz-cite-prefix">On 30=
-6-2024 16:04, Saki Takamachi
      wrote:<br></div><blockquote cite=3D"mid:F709ADD3-502E-418B-82D3-34=
A681EBB7A0@sakiot.com" type=3D"cite"><pre>Hi internals,

I created an RFC and put it in discussion status.
<a class=3D"qt-moz-txt-link-freetext" href=3D"https://wiki.php.net/rfc/a=
dd_bcdivmod_to_bcmath">https://wiki.php.net/rfc/add_bcdivmod_to_bcmath</=
a>

I expect return values will probably be the main topic of discussion.

Regards,

Saki
<br></pre></blockquote><div><br></div><div>Just a suggestion: what about=
 making the returned array an
    associative array ? Like so:<br></div><div> ```<br></div><div> array=
(<br></div><div> &nbsp;&nbsp;&nbsp; 'quotient' =3D&gt; 61,<br></div><div=
> &nbsp;&nbsp;&nbsp; 'remainder' =3D&gt; 1,<br></div><div> );<br></div><=
div> ```<br></div><div> <br></div><div> This would remove the need for d=
evs to remember the order of the
    return values and would make the return value self-documenting.<br><=
/div></blockquote><div><br></div><div>I came here to say the same thing.=
 The best solution would be not having to refer to documentation or expe=
riment with values, and this hits the nail on the head.<br></div><div><b=
r></div><div>The only thing that makes it weird is having to write it ou=
t, which at that point, it is probably faster to type out bcdiv and bcmo=
d separately.<br></div><div><br></div><div>Have you considered simply us=
ing references passed to the function? I feel like that is more idiomati=
cally php.</div><div><br></div><div id=3D"sig121229152">=E2=80=94 Rob<br=
></div></body></html>
--c9403716f7c446d092c617a183892a7c--