Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124096
Message-ID: <c64315af-ba2c-4148-8cb8-b3451d4574bd@bastelstu.be>
Date: Sun, 30 Jun 2024 16:15:35 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] [RFC][Discussion] Enhance JSON error messages
To: juan carlos morales <dev.juan.morales@gmail.com>
Cc: "Gina P. Banyard" <internals@gpb.moe>,
 PHP Internals List <internals@lists.php.net>
References: <CANMwmbP4=cHj0Dye4b2uesefJs2gMPHKRYCSyvd3eaTJ+4cAyQ@mail.gmail.com>
 <KncosRapPMs_3wCzcaQPmMEGpLnYNkSZ9GDmBCEsisLKBR9DDbtxAGKZFD-xlMPxcgmj4CZ5RNxcklikaT9o1TztDtMc7aOD0NnTN5xLfmE=@gpb.moe>
 <CANMwmbOp12Bxi7zHz4kL3NBta7ccBqhkBGabk5TDJE-0CxZOuQ@mail.gmail.com>
 <66420855-9900-48a8-9964-b9dda81a8bdc@bastelstu.be>
 <CANMwmbMC-Q1dhqiG9rGcRqoNETTNQNy-U+hnXx6cmjH-7MFWWw@mail.gmail.com>
Content-Language: en-US
In-Reply-To: <CANMwmbMC-Q1dhqiG9rGcRqoNETTNQNy-U+hnXx6cmjH-7MFWWw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 6/30/24 15:43, juan carlos morales wrote:
> So, what I see here in my shortexperiencie is an RFC with 3 Options

That is not an option. Each RFC needs a clear primary vote that is a 
"Yes/No" vote.

> 1) Enhance the error message we already have
> 
> 2) keep json_last_error_msg as it is and add a new function
> json_last_error_info function
> 
> 3) both
> 

Adjusting error messages to make them better is not something that 
requires an RFC. We do this all the time without an RFC. Here's an 
example PR: https://github.com/php/php-src/pull/14496

A new json_last_error_info() for easier programmatic access of the 
important bits can still be considered, but would not need an RFC either 
from my point of view. It's a simple and obvious addition. Those can be 
done without an RFC, unless someone complains.

Best regards
Tim Düsterhus