Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124093
Precedence: bulk
MIME-Version: 1.0
References: <CANMwmbP4=cHj0Dye4b2uesefJs2gMPHKRYCSyvd3eaTJ+4cAyQ@mail.gmail.com>
 <KncosRapPMs_3wCzcaQPmMEGpLnYNkSZ9GDmBCEsisLKBR9DDbtxAGKZFD-xlMPxcgmj4CZ5RNxcklikaT9o1TztDtMc7aOD0NnTN5xLfmE=@gpb.moe>
 <CANMwmbOp12Bxi7zHz4kL3NBta7ccBqhkBGabk5TDJE-0CxZOuQ@mail.gmail.com> <66420855-9900-48a8-9964-b9dda81a8bdc@bastelstu.be>
In-Reply-To: <66420855-9900-48a8-9964-b9dda81a8bdc@bastelstu.be>
Date: Sun, 30 Jun 2024 10:43:53 -0300
Message-ID: <CANMwmbMC-Q1dhqiG9rGcRqoNETTNQNy-U+hnXx6cmjH-7MFWWw@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC][Discussion] Enhance JSON error messages
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: "Gina P. Banyard" <internals@gpb.moe>, PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000007d9e88061c1bacee"
From: dev.juan.morales@gmail.com (juan carlos morales)

--0000000000007d9e88061c1bacee
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

El El dom, 30 de jun. de 2024 a la(s) 09:02, Tim D=C3=BCsterhus <tim@bastel=
stu.be>
escribi=C3=B3:

> Hi
>
> On 6/28/24 15:49, juan carlos morales wrote:
> > Suggested by Jakub Zelenka (the main arquitect of the JSON part in php
> > basically), in the PULL REQUEST is better to create a brand new
> > function to have detailed error messages when json encoding, decoding,
> > validating, fails.
>
> For the folks following along, I've commented on the PR. I think that
> improving the existing messages is the right choice, not adding new
> functions that users will need to remember to use.
>
> Best regards
> Tim D=C3=BCsterhus
>

Thanks for writting Tim.


So, what I see here in my shortexperiencie is an RFC with 3 Options

1) Enhance the error message we already have

2) keep json_last_error_msg as it is and add a new function
json_last_error_info function

3) both


And let the voting to decide



That is what I see so far


Is evident that everyone agrees is a helpful feature to have better error
understandind

--0000000000007d9e88061c1bacee
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div><br></div><div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=
=3D"gmail_attr">El El dom, 30 de jun. de 2024 a la(s) 09:02, Tim D=C3=BCste=
rhus &lt;<a href=3D"mailto:tim@bastelstu.be">tim@bastelstu.be</a>&gt; escri=
bi=C3=B3:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 =
.8ex;border-left:1px #ccc solid;padding-left:1ex">Hi<br>
<br>
On 6/28/24 15:49, juan carlos morales wrote:<br>
&gt; Suggested by Jakub Zelenka (the main arquitect of the JSON part in php=
<br>
&gt; basically), in the PULL REQUEST is better to create a brand new<br>
&gt; function to have detailed error messages when json encoding, decoding,=
<br>
&gt; validating, fails.<br>
<br>
For the folks following along, I&#39;ve commented on the PR. I think that <=
br>
improving the existing messages is the right choice, not adding new <br>
functions that users will need to remember to use.<br>
<br>
Best regards<br>
Tim D=C3=BCsterhus<br>
</blockquote></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">Than=
ks for writting Tim.</div><div dir=3D"auto"><br></div><div dir=3D"auto"><br=
></div><div dir=3D"auto">So, what I see here in my shortexperiencie is an R=
FC with 3 Options</div><div dir=3D"auto"><br></div><div dir=3D"auto">1) Enh=
ance the error message we already have</div><div dir=3D"auto"><br></div><di=
v dir=3D"auto">2) keep json_last_error_msg as it is and add a new function =
json_last_error_info function</div><div dir=3D"auto"><br></div><div dir=3D"=
auto">3) both=C2=A0</div><div dir=3D"auto"><br></div><div dir=3D"auto"><br>=
</div><div dir=3D"auto">And let the voting to decide=C2=A0</div><div dir=3D=
"auto"><br></div><div dir=3D"auto"><br></div><div dir=3D"auto"><br></div><d=
iv dir=3D"auto">That is what I see so far=C2=A0</div><div dir=3D"auto"><br>=
</div><div dir=3D"auto"><br></div><div dir=3D"auto">Is evident that everyon=
e agrees is a helpful feature to have better error understandind=C2=A0</div=
>

--0000000000007d9e88061c1bacee--