Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124092
Message-ID: <386fa86a-696a-4a03-89d8-87fcf6991138@bastelstu.be>
Date: Sun, 30 Jun 2024 15:28:32 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] [RFC] Lazy Objects
To: Arnaud Le Blanc <arnaud.lb@gmail.com>
Cc: Nicolas Grekas <nicolas.grekas+php@gmail.com>,
 PHP Internals List <internals@lists.php.net>
References: <CAOWwgpmbq5VRrZQvUXDsKiNK4r6+bFA4VxnjQ_U=h8T9r0o3DA@mail.gmail.com>
 <ab83af79-0669-47dd-a3cb-ab72327ae174@bastelstu.be>
 <CAP1Jc13JWVg99AULgzrGXcoCWJtJZGz+nr_VoyUocw8n5n5sfQ@mail.gmail.com>
 <1118bbcd-a7b4-47bf-bf35-1a36ab4628e1@bastelstu.be>
 <CAP1Jc11vNiazMRL8Y-4NcJhsEkg6kgFNKLymTGfEPYRv114oTA@mail.gmail.com>
 <45847b93-02bf-459f-bcd2-81ba35a12c24@bastelstu.be>
Content-Language: en-US
In-Reply-To: <45847b93-02bf-459f-bcd2-81ba35a12c24@bastelstu.be>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 6/30/24 15:08, Tim Düsterhus wrote:
> I've read the updated RFC and it's still not clear to me that returning
> an arbitrary “actual instance” object is sound. Especially when private
> properties - which for all intents and purposes are not visible outside
> of the class - are involved. Consider the following:

I initially wanted to include any new questions in a completely separate 
thread to keep stuff organized, but I realized that the cloning behavior 
is very closely related to what I already remarked above:

The cloning behavior appears to be unsound to me. Consider the following:

     class A {
        public function __construct(
          public string $property,
        ) {}
     }
     class B extends A {
        public function foo() { }
     }

     function only_b(B $b) { $b->foo(); }

     $r = new ReflectionClass(B::class);
     $b = $r->newLazyProxy(function ($obj) {
       return new A('value');
     });

     $b->property = 'init_please';

     $notActuallyB = clone $b;
     only_b($b); // legal
     only_b($notActuallyB); // illegal

I'm cloning what I believe to be an instance of B, but get back an A.

Best regards
Tim Düsterhus