Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124088
Message-ID: <66420855-9900-48a8-9964-b9dda81a8bdc@bastelstu.be>
Date: Sun, 30 Jun 2024 14:02:18 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] [RFC][Discussion] Enhance JSON error messages
To: juan carlos morales <dev.juan.morales@gmail.com>,
 "Gina P. Banyard" <internals@gpb.moe>
Cc: PHP Internals List <internals@lists.php.net>
References: <CANMwmbP4=cHj0Dye4b2uesefJs2gMPHKRYCSyvd3eaTJ+4cAyQ@mail.gmail.com>
 <KncosRapPMs_3wCzcaQPmMEGpLnYNkSZ9GDmBCEsisLKBR9DDbtxAGKZFD-xlMPxcgmj4CZ5RNxcklikaT9o1TztDtMc7aOD0NnTN5xLfmE=@gpb.moe>
 <CANMwmbOp12Bxi7zHz4kL3NBta7ccBqhkBGabk5TDJE-0CxZOuQ@mail.gmail.com>
Content-Language: en-US
In-Reply-To: <CANMwmbOp12Bxi7zHz4kL3NBta7ccBqhkBGabk5TDJE-0CxZOuQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 6/28/24 15:49, juan carlos morales wrote:
> Suggested by Jakub Zelenka (the main arquitect of the JSON part in php
> basically), in the PULL REQUEST is better to create a brand new
> function to have detailed error messages when json encoding, decoding,
> validating, fails.

For the folks following along, I've commented on the PR. I think that 
improving the existing messages is the right choice, not adding new 
functions that users will need to remember to use.

Best regards
Tim Düsterhus