Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:123947 X-Original-To: internals@lists.php.net Delivered-To: internals@lists.php.net Received: from php-smtp4.php.net (php-smtp4.php.net [45.112.84.5]) by qa.php.net (Postfix) with ESMTPS id 6A1D21A009C for ; Thu, 27 Jun 2024 17:27:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=php.net; s=mail; t=1719509301; bh=KpMc0cnDwAoFInnYoSIziOQYnXmyJSCrkOp/3hYPQZM=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Yhocm2QEL8biYI4MiQ2mA9r9GsD7sr2JlK4JMs2YolV57DaED6dccyLHLsioGeD9o 3C7Nb7Gfq6sa+PmugqYRRTmsikQub46WnGkGOU1Jd69LeqAFiS8BRZfpawwdgOtY8X +ZSx3ca10CxYIJwXBsLq2v5Uad5a1mG13n8Ito81nYx3uOxIkHpPiDOxYDZdkVAdLo gl9UBVJi0kGza+0TimqLgReH2KCPfBEtDMMtVZlUlYn07SNAVS4uuY4PTYR51+d0SU KXbKyLhOR3inyjml2P3d8Nwzy16T9kPPyrPtbJXlThuUGbC2L2R4HjXDaKrBznxQpn wFb2MUU6qerTQ== Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id DF351180ECF for ; Thu, 27 Jun 2024 17:28:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_50,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,DMARC_PASS,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=4.0.0 X-Spam-Virus: Error (Cannot connect to unix socket '/var/run/clamav/clamd.ctl': connect: Connection refused) X-Envelope-From: Received: from chrono.xqk7.com (chrono.xqk7.com [176.9.45.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Thu, 27 Jun 2024 17:28:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bastelstu.be; s=mail20171119; t=1719509221; bh=8r6KXfCcBMZYWlKtQRTZRBNY5BkSro8iA8KqvzvcDvc=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type:from:to:cc:subject:message-id; b=ZXZVnXuNuw7E3r97r4jujfFFJnZcrpaUIREfFD3OFKkL7SuvQ5ljcfSaiQHSfHdWb O4mBGurYC+fN/7p65ZVZbH2+NCYM2cclTtfSn2oOCjCIC0dpccvJElyJhKH1eK1QQJ R+HVdDCNor0gopdQ8nTPwQzyI7XH27QuT4iaQWzZQ8FOu7CTdH0sf6PDl4IGtOqg0+ osX4d5CqLl9ksmoA62ExNuXNcD6lXA4+wjxBV09z4woyQVl48Y3MUJkQU6FXBMvK2U PTmYpCRQLS5mRfIiN6QL33e8OkdTq1O4dYrDQ7n7uB3+qNPc0rNRkfFnXVfdF8JVK9 kVbiSjKO9dFMw== Message-ID: Date: Thu, 27 Jun 2024 19:26:59 +0200 Precedence: bulk list-help: list-post: List-Id: internals.lists.php.net MIME-Version: 1.0 Subject: Re: [PHP-DEV] [RFC] Deprecations for PHP 8.4 To: Chuck Adams , PHP internals References: <0BBF41AF-2516-44D4-A102-73580C5ED373@newclarity.net> <2A60B0A8-3105-4DE5-8C8A-8BDAB330C4BC@koalephant.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=) Hi On 6/27/24 19:09, Chuck Adams wrote: > Personally I say let strtok be and just admit in the documentation that it’s weird because C. strtok() is not weird because C. It does not rely on the libc strtok() function and did not since at least 1999 (and likely never did): https://github.com/php/php-src/commit/257de2baded9330ff392f33fd5a7cc0ba271e18d#diff-fcf8a2a38ee4a0e3e2cb7c47251c9920ba8c5886d85969f676f9ddbee7aba503R332 strtok() is weird, because someone believed that relying on global state was good API design. I find that excusable, because it happened more than a quarter of a century ago. Best regards Tim Düsterhus