Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123946
Message-ID: <3f230c9b-7aca-4bce-ab2a-544a10bf128f@bastelstu.be>
Date: Thu, 27 Jun 2024 19:20:06 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] [RFC] Deprecations for PHP 8.4
To: Markus Podar <markus.podar@gmail.com>, internals@lists.php.net
References: <bw20I5b7ly3lSbI-2Bv3kfrfTVJbDo5RhwBiQa1PEwuLjprDJWptPajLiaialj1RLVKu7z1j0MofJUhhRVtzT_5i2E11oKeQx_VMUxnKhUE=@gpb.moe>
 <E146A171-CFA6-4E3F-91AA-2ACE7710A6D9@newclarity.net>
 <dbGe34EpQtjyP7ja7aUHnZYwmtupxeLd7EoOv3JjQMSh_UqoMrbqo5PkxrlIiaXJePC1-TfLyyblz5QDM13OkitgBqKPuSvh28WiJFh7qJI=@gpb.moe>
 <B958318C-B61D-4618-BA7D-3BF204C5B3CD@newclarity.net>
 <ca140b2c-51ff-4217-8f66-23f877ac0cb8@gmail.com>
Content-Language: en-US
In-Reply-To: <ca140b2c-51ff-4217-8f66-23f877ac0cb8@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 6/27/24 09:44, Markus Podar wrote:
> 👎 on deprecating it; if a gotcha with it is not clear (e.g. using it in
> different scopes, as this was brought up), I see this rather as a
> "documentation problem".

If one can easily use a function incorrectly in a way that is not 
*immediately* apparent, then I consider the function to be badly 
designed. In my book this includes all functions that rely on global 
state, because that will lead to spooky action from a distance sooner 
rather than later.

Here's an example (https://3v4l.org/XNl3X):

     <?php

     function processInner($line) {
         $tok = strtok($line, ",");

         while ($tok !== false) {
             echo "Entry=$tok\n";
             $tok = strtok(",");
         }
     }

     function processOuter($csv) {
         $line = strtok($csv, "\n");

         while ($line !== false) {
             processInner($line);
             $line = strtok("\n");
         }
     }

     processOuter("foo,bar,baz\na,b,c\n1,2,3");

Each of the functions individually is "fine" (for an appropriate 
definition of fine), but combined they are buggy. This becomes worse 
when the processInner() function is part of a third party library you 
don't control. Do you check each update of that library to see if it 
added or removed any strtok() calls anywhere?

Pointing towards the documentation is not an excuse for bad API design.

Best regards
Tim Düsterhus