Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123944
Message-ID: <6a7c17d0-011f-413c-b7d6-23ea0019e151@bastelstu.be>
Date: Thu, 27 Jun 2024 19:08:53 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] [RFC] Deprecations for PHP 8.4
To: "Gina P. Banyard" <internals@gpb.moe>, Mike Schinkel <mike@newclarity.net>
Cc: PHP internals <internals@lists.php.net>
References: <bw20I5b7ly3lSbI-2Bv3kfrfTVJbDo5RhwBiQa1PEwuLjprDJWptPajLiaialj1RLVKu7z1j0MofJUhhRVtzT_5i2E11oKeQx_VMUxnKhUE=@gpb.moe>
 <E146A171-CFA6-4E3F-91AA-2ACE7710A6D9@newclarity.net>
 <dbGe34EpQtjyP7ja7aUHnZYwmtupxeLd7EoOv3JjQMSh_UqoMrbqo5PkxrlIiaXJePC1-TfLyyblz5QDM13OkitgBqKPuSvh28WiJFh7qJI=@gpb.moe>
 <B958318C-B61D-4618-BA7D-3BF204C5B3CD@newclarity.net>
 <uE8fty0oxYjGeo11h28dcXlCSaLwUpPfXT2msoy5eDAQRqPVFSWpG6pn1rwPHaRh9l2WWAOSJClb60LKjlur8qnsogEP1IH3za6wsEBgZFc=@gpb.moe>
Content-Language: en-US
In-Reply-To: <uE8fty0oxYjGeo11h28dcXlCSaLwUpPfXT2msoy5eDAQRqPVFSWpG6pn1rwPHaRh9l2WWAOSJClb60LKjlur8qnsogEP1IH3za6wsEBgZFc=@gpb.moe>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 6/26/24 14:14, Gina P. Banyard wrote:
>> Regarding explode($delimiter, $str)[0] — unless it is to be special-cased during compilation —it is a really inefficient way to find the substring up to the first character, especially for large strings and/or when in a tight loop where the explode is contained in a called function
> 
> Then use a regex: https://3v4l.org/SGWL5
> 
> Or a combination of strpos and substr.
> 
> I'd bet that both of these solutions would use less memory, and I would guess the PCRE one should also be better for performance (although not benchmarked) as it is highly specialized in that task.
> 
> There are *plenty* of solutions to the specific problem you pose here, and thus many different solutions more or less appropriate.

FWIW: `explode()` also has a third parameter to limit the number of 
segments to return. If you always want just one, you can set the 
parameter to `2` to prevent further processing from happening after 
encountering the first delimiter.

Best regards
Tim Düsterhus