Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123920
Date: Thu, 27 Jun 2024 04:09:56 +0000
To: juan carlos morales <dev.juan.morales@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC][Discussion] Enhance JSON error messages
Message-ID: <KncosRapPMs_3wCzcaQPmMEGpLnYNkSZ9GDmBCEsisLKBR9DDbtxAGKZFD-xlMPxcgmj4CZ5RNxcklikaT9o1TztDtMc7aOD0NnTN5xLfmE=@gpb.moe>
In-Reply-To: <CANMwmbP4=cHj0Dye4b2uesefJs2gMPHKRYCSyvd3eaTJ+4cAyQ@mail.gmail.com>
References: <CANMwmbP4=cHj0Dye4b2uesefJs2gMPHKRYCSyvd3eaTJ+4cAyQ@mail.gmail.com>
Feedback-ID: 96993444:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: internals@gpb.moe ("Gina P. Banyard")

On Wednesday, 26 June 2024 at 15:11, juan carlos morales <dev.juan.morales@=
gmail.com> wrote:

> I also think it would be very useful to have better error messages.
>=20
> At the moment, we get things like "Syntax Error" ... period, no clue
> where the JSON is corrupt or anything else. With big JSONs is very
> cumberstone to get to the line and character position where the JSON
> is corrupt .... for example.
>=20
> I am already working in a change that would improve error messages
> while working with JSONs.
>=20
> What I am very close to achieve is to have error messages like "Syntax
> Error - at character position X near content Y" .... something like
> that.
>=20
> I already know that I can do it, actually there is a Work In Progress
> Pull Request for this :
>=20
> https://github.com/php/php-src/pull/14672
>=20
>=20
> I repeat, is work in progress. BUT it can be done. Maybe my approach
> is not the best ... but one way or another .... it can be done.
>=20
> Please let me know your ideas, thoughts about this.
>=20
> Please, dont kill me for the actual code, is WIP.
>=20
> Thanks in advance to everyone.
>=20
> Juan

Hello Juan,

I'm in favour of this, but also I do not think this needs an RFC.
This is just an enhancement to our current crappy parsing errors,
and an RFC feels very much overkill for this.

Best regards,

Gina P. Banyard