Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123871
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-538-g1508afaa2-fm-20240616.001-g1508afaa
Precedence: bulk
MIME-Version: 1.0
Message-ID: <3b050050-e6fd-4a3a-839e-e68000445909@app.fastmail.com>
In-Reply-To: 
 <CANMwmbP4=cHj0Dye4b2uesefJs2gMPHKRYCSyvd3eaTJ+4cAyQ@mail.gmail.com>
References: 
 <CANMwmbP4=cHj0Dye4b2uesefJs2gMPHKRYCSyvd3eaTJ+4cAyQ@mail.gmail.com>
Date: Wed, 26 Jun 2024 16:26:56 +0000
To: "php internals" <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC][Discussion] Enhance JSON error messages
Content-Type: text/plain
From: larry@garfieldtech.com ("Larry Garfield")

On Wed, Jun 26, 2024, at 2:11 PM, juan carlos morales wrote:
> Hello Internals.
>
> I'm here to discuss an improvement in error messages when dealing with
> JSON in PHP.
>
> After watching Derick Rethans speak at the UK PHP Conference:
>
> https://youtu.be/3U0DGhzSH2U?feature=shared&t=2483
>
> I also think it would be very useful to have better error messages.
>
> At the moment, we get things like "Syntax Error" ... period, no clue
> where the JSON is corrupt or anything else. With big JSONs is very
> cumberstone to get to the line and character position where the JSON
> is corrupt .... for example.
>
> I am already working in a change that would improve error messages
> while working with JSONs.
>
> What I am very close to achieve is to have error messages like "Syntax
> Error - at character position X near content Y" .... something like
> that.
>
> I already know that I can do it, actually there is a Work In Progress
> Pull Request for this :
>
> https://github.com/php/php-src/pull/14672
>
>
> I repeat, is work in progress. BUT it can be done. Maybe my approach
> is not the best ... but one way or another .... it can be done.
>
> Please let me know your ideas, thoughts about this.
>
> Please, dont kill me for the actual code, is WIP.
>
> Thanks in advance to everyone.
>
> Juan

I cannot comment on the implementation, but I am always in favor of error messages that do a better job of telling you what you need to fix.

--Larry Garfield